Revert "Revert of Fix hanging on browser shutdown. (patchset #1 id:1 of https://codereview.chromium…

Revert "Revert of Fix hanging on browser shutdown. (patchset #1 id:1 of https://codereview.chromium.org/1990453002/ )"

Reason for revert:
It seems that my initial CL(https://codereview.chromium.org/1990453002)
is unrelated to the problem on Linux build bot.
The test still failing ATM, even after revert (for example, see
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/20141).

This CL should check builds.

Original issue's description:
> Revert of Fix hanging on browser shutdown. (patchset #1 id:1 of https://codereview.chromium.org/1990453002/ )
>
> Reason for revert:
> Judging by the CL description I suspect this is causing a shutdown crash on the Linux ChromiumOS Tests (1) bot:
> https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/20129
>
> Committed: https://crrev.com/44fe05658249a69e0a1c769e6d2c0e0cf7de1f1b
> Cr-Commit-Position: refs/heads/master@{#394395}

BUG=486077
Committed: https://crrev.com/80c690a0c6184bb714ad82bfc7af851b8475388c
Cr-Commit-Position: refs/heads/master@{#395037}

[Andrey Kraynov, 2016-05-18 17:51:57]

iceman@yandex-team.ru changed reviewers:
+ amistry@chromium.org, dmazzoni@chromium.org

[Andrey Kraynov, 2016-05-18 17:51:58]

As finnur@ recommended, with this revert I want to check that my initial CL is
unrelated to fest failure.

+amistry@ as a sheriff (sorry if I'm wrong with that)

Could someone trigger trybots, please?
Thanks in advance!

[nektarios, 2016-05-18 17:53:29]

nektar@chromium.org changed reviewers:
+ nektar@chromium.org

[nektarios, 2016-05-18 17:53:29]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2016-05-18 17:53:30]

lgtm

[commit-bot: I haz the power, 2016-05-18 17:54:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988213002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988213002/1

[commit-bot: I haz the power, 2016-05-18 18:04:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-18 18:04:14]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Andrey Kraynov, 2016-05-19 15:49:15]

On 2016/05/18 17:53:30, nektarios wrote:
> lgtm

Thanks!

It seems that the build is fine, but to land this CL I still need an approvement
from an owner of these files.
dmazzoni@, could you take a look, please?

[Andrey Kraynov, 2016-05-19 15:49:40]

Description was changed from

==========
Revert "Revert of Fix hanging on browser shutdown. (patchset #1 id:1 of
https://codereview.chromium.org/1990453002/ )"

Reason for revert:
It seems that my initial CL(https://codereview.chromium.org/1990453002)
is unrelated to the problem on Linux build bot.
The test still failing ATM, event after revert (for example, see
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...).

This CL should check builds.

Original issue's description:
> Revert of Fix hanging on browser shutdown. (patchset #1 id:1 of
https://codereview.chromium.org/1990453002/ )
>
> Reason for revert:
> Judging by the CL description I suspect this is causing a shutdown crash on
the Linux ChromiumOS Tests (1) bot:
>
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
>
> Committed: https://crrev.com/44fe05658249a69e0a1c769e6d2c0e0cf7de1f1b
> Cr-Commit-Position: refs/heads/master@{#394395}

BUG=486077
==========

to

==========
Revert "Revert of Fix hanging on browser shutdown. (patchset #1 id:1 of
https://codereview.chromium.org/1990453002/ )"

Reason for revert:
It seems that my initial CL(https://codereview.chromium.org/1990453002)
is unrelated to the problem on Linux build bot.
The test still failing ATM, even after revert (for example, see
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...).

This CL should check builds.

Original issue's description:
> Revert of Fix hanging on browser shutdown. (patchset #1 id:1 of
https://codereview.chromium.org/1990453002/ )
>
> Reason for revert:
> Judging by the CL description I suspect this is causing a shutdown crash on
the Linux ChromiumOS Tests (1) bot:
>
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
>
> Committed: https://crrev.com/44fe05658249a69e0a1c769e6d2c0e0cf7de1f1b
> Cr-Commit-Position: refs/heads/master@{#394395}

BUG=486077
==========

[dmazzoni, 2016-05-19 17:40:26]

lgtm

[Andrey Kraynov, 2016-05-20 08:09:52]

The CQ bit was checked by iceman@yandex-team.ru

[commit-bot: I haz the power, 2016-05-20 08:10:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988213002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988213002/1

[commit-bot: I haz the power, 2016-05-20 08:54:27]

Description was changed from

==========
Revert "Revert of Fix hanging on browser shutdown. (patchset #1 id:1 of
https://codereview.chromium.org/1990453002/ )"

Reason for revert:
It seems that my initial CL(https://codereview.chromium.org/1990453002)
is unrelated to the problem on Linux build bot.
The test still failing ATM, even after revert (for example, see
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...).

This CL should check builds.

Original issue's description:
> Revert of Fix hanging on browser shutdown. (patchset #1 id:1 of
https://codereview.chromium.org/1990453002/ )
>
> Reason for revert:
> Judging by the CL description I suspect this is causing a shutdown crash on
the Linux ChromiumOS Tests (1) bot:
>
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
>
> Committed: https://crrev.com/44fe05658249a69e0a1c769e6d2c0e0cf7de1f1b
> Cr-Commit-Position: refs/heads/master@{#394395}

BUG=486077
==========

to

==========
Revert "Revert of Fix hanging on browser shutdown. (patchset #1 id:1 of
https://codereview.chromium.org/1990453002/ )"

Reason for revert:
It seems that my initial CL(https://codereview.chromium.org/1990453002)
is unrelated to the problem on Linux build bot.
The test still failing ATM, even after revert (for example, see
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...).

This CL should check builds.

Original issue's description:
> Revert of Fix hanging on browser shutdown. (patchset #1 id:1 of
https://codereview.chromium.org/1990453002/ )
>
> Reason for revert:
> Judging by the CL description I suspect this is causing a shutdown crash on
the Linux ChromiumOS Tests (1) bot:
>
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
>
> Committed: https://crrev.com/44fe05658249a69e0a1c769e6d2c0e0cf7de1f1b
> Cr-Commit-Position: refs/heads/master@{#394395}

BUG=486077
==========

[commit-bot: I haz the power, 2016-05-20 08:54:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-20 08:56:24]

Description was changed from

==========
Revert "Revert of Fix hanging on browser shutdown. (patchset #1 id:1 of
https://codereview.chromium.org/1990453002/ )"

Reason for revert:
It seems that my initial CL(https://codereview.chromium.org/1990453002)
is unrelated to the problem on Linux build bot.
The test still failing ATM, even after revert (for example, see
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...).

This CL should check builds.

Original issue's description:
> Revert of Fix hanging on browser shutdown. (patchset #1 id:1 of
https://codereview.chromium.org/1990453002/ )
>
> Reason for revert:
> Judging by the CL description I suspect this is causing a shutdown crash on
the Linux ChromiumOS Tests (1) bot:
>
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
>
> Committed: https://crrev.com/44fe05658249a69e0a1c769e6d2c0e0cf7de1f1b
> Cr-Commit-Position: refs/heads/master@{#394395}

BUG=486077
==========

to

==========
Revert "Revert of Fix hanging on browser shutdown. (patchset #1 id:1 of
https://codereview.chromium.org/1990453002/ )"

Reason for revert:
It seems that my initial CL(https://codereview.chromium.org/1990453002)
is unrelated to the problem on Linux build bot.
The test still failing ATM, even after revert (for example, see
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...).

This CL should check builds.

Original issue's description:
> Revert of Fix hanging on browser shutdown. (patchset #1 id:1 of
https://codereview.chromium.org/1990453002/ )
>
> Reason for revert:
> Judging by the CL description I suspect this is causing a shutdown crash on
the Linux ChromiumOS Tests (1) bot:
>
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
>
> Committed: https://crrev.com/44fe05658249a69e0a1c769e6d2c0e0cf7de1f1b
> Cr-Commit-Position: refs/heads/master@{#394395}

BUG=486077

Committed: https://crrev.com/80c690a0c6184bb714ad82bfc7af851b8475388c
Cr-Commit-Position: refs/heads/master@{#395037}
==========

[commit-bot: I haz the power, 2016-05-20 08:56:25]

Patchset 1 (id:??) landed as
https://crrev.com/80c690a0c6184bb714ad82bfc7af851b8475388c
Cr-Commit-Position: refs/heads/master@{#395037}

[Mostyn Bramley-Moore, 2016-05-20 09:40:38]

This change is missing my fixup, I will queue that now...
https://codereview.chromium.org/1989233002/

[Andrey Kraynov, 2016-05-20 11:07:47]

On 2016/05/20 09:40:38, Mostyn Bramley-Moore wrote:
> This change is missing my fixup, I will queue that now...
> https://codereview.chromium.org/1989233002/

Thanks!
I missed your CL, because you assigned for review 'kraynov@' but not
'iceman@yandex-team.ru' =)