Test for form submission targeting remote frame.

components/test_runner/test_runner.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/test_runner/test_runner.h"
 
 #include <stddef.h>
 #include <limits>
 #include <utility>
 
@@ skipping 1910 matching lines @@
   bool Run(WebTestDelegate* delegate, WebView*) override {
     delegate->GoToOffset(distance_);
     return true; // FIXME: Did it really start a navigation?
   }
 
  private:
   int distance_;
 };
 
 void TestRunner::NotifyDone() {
-  // Test didn't timeout. Kill the pending callbacks.
-  weak_factory_.InvalidateWeakPtrs();

[Łukasz Anforowicz, 2016/05/19 23:01:16]

If I don't remove this, then calling testRunner.notifyDone() will invalidate
TestRunner's weak pointers and therefore will invalidate all TestRunner-specific
bindings held by TestRunnerBindings.  This undesirable behavior of
testRunner.notifyDone was introduced in
https://codereview.chromium.org/1852603002 which got rid of
TestRunner::task_list_ and reused TestRunner::weak_factory_ for cancellation of
callbacks.

I think it is fine to remove this call, because everything will still be
cleaned-up before the next test, because we call
weak_factory_.InvalidateWeakPtrs() from TestRunner::Reset.

One could argue that we might want to still cancel pending callbacks, to avoid
any activity while BlinkTestRunner is working on creating the final test dump
(text, pixel, etc.).  To accomplish this, we might move the
weak_factory_.InvalidateWeakPtrs() call into *Complete*NotifyDone method, right
before it calls delegate_->TestFinished().  I think this would be a wrong thing
to do because it wouldn't really help: it wouldn't stop *future* callbacks (i.e.
using weak pointers obtained in the future, before the next call to
TestRunner::Reset).  Since doing this wouldn't really help, let's just not add
this extra complexity.

I do note that all the tests pass without the removed code.

Sounds good?

-
   CompleteNotifyDone();
 }
 
 void TestRunner::WaitUntilDone() {
   layout_test_runtime_flags_.set_wait_until_done(true);
   OnLayoutTestRuntimeFlagsChanged();
 }
 
 void TestRunner::QueueBackNavigation(int how_far_back) {
   work_queue_.AddWork(new WorkItemBackForward(-how_far_back));
@@ skipping 774 matching lines @@
 
 void TestRunner::CompleteNotifyDone() {
   if (layout_test_runtime_flags_.wait_until_done() && !topLoadingFrame() &&
       work_queue_.is_empty())
     delegate_->TestFinished();
   layout_test_runtime_flags_.set_wait_until_done(false);
   OnLayoutTestRuntimeFlagsChanged();
 }
 
 }  // namespace test_runner