Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1989093003: Remove the prefinalizer of Resource (Closed)

Created:
4 years, 7 months ago by hiroshige
Modified:
4 years, 7 months ago
Reviewers:
Nate Chapin, yhirano
CC:
chromium-reviews, tyoshino+watch_chromium.org, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, gavinp+loader_chromium.org, darktears, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@temp1985033003
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the prefinalizer of Resource https://codereview.chromium.org/1985033003 removed the use of the prefinalizer from Inspector. This CL removes the use of the prefinalizer from StyleSheetContents by adding WeakMember of Resource to StyleSheetContents, and removes the prefinalizer. BUG=603462 Committed: https://crrev.com/352031704d3923226e3abc0d1ee1ec9ea04c3465 Cr-Commit-Position: refs/heads/master@{#394900}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -28 lines) Patch
M third_party/WebKit/Source/core/css/StyleSheetContents.h View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleSheetContents.cpp View 4 chunks +13 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp View 1 chunk +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.h View 3 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 2 chunks +0 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989093003/1
4 years, 7 months ago (2016-05-18 05:47:06 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/7431) ios-device-gn on ...
4 years, 7 months ago (2016-05-18 05:49:17 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989093003/1
4 years, 7 months ago (2016-05-19 03:48:25 UTC) #6
hiroshige
PTAL.
4 years, 7 months ago (2016-05-19 05:37:14 UTC) #11
Nate Chapin
LGTM!
4 years, 7 months ago (2016-05-19 21:38:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989093003/1
4 years, 7 months ago (2016-05-19 23:11:42 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 23:18:05 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 23:19:23 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/352031704d3923226e3abc0d1ee1ec9ea04c3465
Cr-Commit-Position: refs/heads/master@{#394900}

Powered by Google App Engine
This is Rietveld 408576698