[DevTools] Use registerWeakMembers in NetworkResourcesData.

[DevTools] Use registerWeakMembers in NetworkResourcesData.

We have custom plumbing from pre-finalizer via InspectorInstrumentation::willDestroyResource, which is no better than intended for this purpose registerWeakMembers call.

BUG=603462
Committed: https://crrev.com/a25ff64ce15df2a38c3bf3f92f3272080e5640f5
Cr-Commit-Position: refs/heads/master@{#394567}

[dgozman, 2016-05-17 18:07:45]

Description was changed from

==========
Use registerWeakMembers in NetworkResourcesData instead of custom plumbing from
pre-finalizer.

BUG=none
==========

to

==========
[DevTools] Use registerWeakMembers in NetworkResourcesData.

We have custom plumbing from pre-finalizer via
InspectorInstrumentation::willDestroyResource, which is no better than intended
for these purposes registerWeakMembers call.

BUG=none
==========

[dgozman, 2016-05-17 18:08:33]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org, hiroshige@chromium.org

[dgozman, 2016-05-17 18:08:33]

Could you please take a look?

[Nate Chapin, 2016-05-17 18:23:36]

japhet@chromium.org changed reviewers:
+ japhet@chromium.org

[Nate Chapin, 2016-05-17 18:23:36]

Quick driveby comment...

https://codereview.chromium.org/1985033003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fetch/Resource.cpp (left):

https://codereview.chromium.org/1985033003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/Resource.cpp:330:
InspectorInstrumentation::willDestroyResource(this);
This is the last usage of InspectorInstrumentation in core/fetch/. Would you
mind removing the #include in this file and the exception for
InspectorInstrumentation.h in core/fetch/DEPS? Thanks!

[caseq, 2016-05-17 18:24:19]

lgtm

[dgozman, 2016-05-17 18:34:26]

https://codereview.chromium.org/1985033003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fetch/Resource.cpp (left):

https://codereview.chromium.org/1985033003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/Resource.cpp:330:
InspectorInstrumentation::willDestroyResource(this);
On 2016/05/17 18:23:36, Nate Chapin wrote:
> This is the last usage of InspectorInstrumentation in core/fetch/. Would you
> mind removing the #include in this file and the exception for
> InspectorInstrumentation.h in core/fetch/DEPS? Thanks!

Done.

[Nate Chapin, 2016-05-17 18:40:47]

On 2016/05/17 18:34:26, dgozman wrote:
>
https://codereview.chromium.org/1985033003/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/fetch/Resource.cpp (left):
> 
>
https://codereview.chromium.org/1985033003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/fetch/Resource.cpp:330:
> InspectorInstrumentation::willDestroyResource(this);
> On 2016/05/17 18:23:36, Nate Chapin wrote:
> > This is the last usage of InspectorInstrumentation in core/fetch/. Would you
> > mind removing the #include in this file and the exception for
> > InspectorInstrumentation.h in core/fetch/DEPS? Thanks!
> 
> Done.

LGTM, thanks again.

[hiroshige, 2016-05-18 05:06:22]

lgtm, thanks!

Could you add BUG=603462 to CL description because this is related to
https://codereview.chromium.org/1807323002/?

[dgozman, 2016-05-18 05:43:40]

Description was changed from

==========
[DevTools] Use registerWeakMembers in NetworkResourcesData.

We have custom plumbing from pre-finalizer via
InspectorInstrumentation::willDestroyResource, which is no better than intended
for these purposes registerWeakMembers call.

BUG=none
==========

to

==========
[DevTools] Use registerWeakMembers in NetworkResourcesData.

We have custom plumbing from pre-finalizer via
InspectorInstrumentation::willDestroyResource, which is no better than intended
for these purposes registerWeakMembers call.

BUG= 603462
==========

[dgozman, 2016-05-18 05:43:52]

On 2016/05/18 05:06:22, hiroshige wrote:
> lgtm, thanks!
> 
> Could you add BUG=603462 to CL description because this is related to
> https://codereview.chromium.org/1807323002/

Sure!

[dgozman, 2016-05-18 05:44:26]

Description was changed from

==========
[DevTools] Use registerWeakMembers in NetworkResourcesData.

We have custom plumbing from pre-finalizer via
InspectorInstrumentation::willDestroyResource, which is no better than intended
for these purposes registerWeakMembers call.

BUG= 603462
==========

to

==========
[DevTools] Use registerWeakMembers in NetworkResourcesData.

We have custom plumbing from pre-finalizer via
InspectorInstrumentation::willDestroyResource, which is no better than intended
for this purpose registerWeakMembers call.

BUG= 603462
==========

[dgozman, 2016-05-18 05:44:39]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-05-18 05:44:39]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/1985033003/#ps20001
(title: "removed instrumentation from deps")

[commit-bot: I haz the power, 2016-05-18 05:45:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1985033003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1985033003/20001

[commit-bot: I haz the power, 2016-05-18 05:47:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-18 05:47:12]

Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[dgozman, 2016-05-18 20:36:22]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-05-18 20:36:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
hiroshige@chromium.org, caseq@chromium.org, japhet@chromium.org
Link to the patchset: https://codereview.chromium.org/1985033003/#ps40001
(title: "rebased, removed more code")

[commit-bot: I haz the power, 2016-05-18 20:36:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1985033003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1985033003/40001

[commit-bot: I haz the power, 2016-05-18 22:03:22]

Description was changed from

==========
[DevTools] Use registerWeakMembers in NetworkResourcesData.

We have custom plumbing from pre-finalizer via
InspectorInstrumentation::willDestroyResource, which is no better than intended
for this purpose registerWeakMembers call.

BUG= 603462
==========

to

==========
[DevTools] Use registerWeakMembers in NetworkResourcesData.

We have custom plumbing from pre-finalizer via
InspectorInstrumentation::willDestroyResource, which is no better than intended
for this purpose registerWeakMembers call.

BUG= 603462
==========

[commit-bot: I haz the power, 2016-05-18 22:03:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-18 22:05:00]

Description was changed from

==========
[DevTools] Use registerWeakMembers in NetworkResourcesData.

We have custom plumbing from pre-finalizer via
InspectorInstrumentation::willDestroyResource, which is no better than intended
for this purpose registerWeakMembers call.

BUG= 603462
==========

to

==========
[DevTools] Use registerWeakMembers in NetworkResourcesData.

We have custom plumbing from pre-finalizer via
InspectorInstrumentation::willDestroyResource, which is no better than intended
for this purpose registerWeakMembers call.

BUG= 603462

Committed: https://crrev.com/a25ff64ce15df2a38c3bf3f92f3272080e5640f5
Cr-Commit-Position: refs/heads/master@{#394567}
==========

[commit-bot: I haz the power, 2016-05-18 22:05:02]

Patchset 3 (id:??) landed as
https://crrev.com/a25ff64ce15df2a38c3bf3f92f3272080e5640f5
Cr-Commit-Position: refs/heads/master@{#394567}