Move clearAnimatedType() up the stack

Move clearAnimatedType() up the stack

This is in preparation for locking the animated property type for the
resulting animation while the accumulated animation is computed. There
seems to be a crash due to the animated property type being cleared
too early. To catch this crash at the point of error, the plan is to
lock the animated property type of the result animation during
processing, and guard for clearing the animation property while the
lock is held (in clearAnimatedType()).

For SMILTimeContainer::updateAnimations() to have a chance of
unlocking the animated property _before_ clearAnimatedType() is
called, we need to move the call up to
SMILTimeContainer::updateAnimations(). (The assumption is that moving
the call shouldn't make a difference since
SMILTimeContainer::updateAnimations() is the only call-site for
SVGSMILElement::progress() and the intermediate code shouldn't depend
on the animated property.)

Since the clearing of property type and nullifying of resultElement
seems tied together, grouping them makes sense regardless of the crash
chase.

BUG=581546
Committed: https://crrev.com/8ac7017db3685604db2d79d8e667ba1d7cf463a2
Cr-Commit-Position: refs/heads/master@{#394698}

[davve, 2016-05-18 14:26:49]

The CQ bit was checked by davve@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-18 14:27:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1989033003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1989033003/1

[davve, 2016-05-18 14:27:13]

davve@opera.com changed reviewers:
+ fs@opera.com

[fs, 2016-05-18 15:59:59]

Make sense. LGTM.

[commit-bot: I haz the power, 2016-05-18 16:16:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-18 16:16:45]

Dry run: This issue passed the CQ dry run.

[davve, 2016-05-19 06:30:57]

The CQ bit was checked by davve@opera.com

[commit-bot: I haz the power, 2016-05-19 06:31:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1989033003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1989033003/1

[commit-bot: I haz the power, 2016-05-19 06:35:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-19 06:37:15]

Description was changed from

==========
Move clearAnimatedType() up the stack

This is in preparation for locking the animated property type for the
resulting animation while the accumulated animation is computed. There
seems to be a crash due to the animated property type being cleared
too early. To catch this crash at the point of error, the plan is to
lock the animated property type of the result animation during
processing, and guard for clearing the animation property while the
lock is held (in clearAnimatedType()).

For SMILTimeContainer::updateAnimations() to have a chance of
unlocking the animated property _before_ clearAnimatedType() is
called, we need to move the call up to
SMILTimeContainer::updateAnimations(). (The assumption is that moving
the call shouldn't make a difference since
SMILTimeContainer::updateAnimations() is the only call-site for
SVGSMILElement::progress() and the intermediate code shouldn't depend
on the animated property.)

Since the clearing of property type and nullifying of resultElement
seems tied together, grouping them makes sense regardless of the crash
chase.

BUG=581546
==========

to

==========
Move clearAnimatedType() up the stack

This is in preparation for locking the animated property type for the
resulting animation while the accumulated animation is computed. There
seems to be a crash due to the animated property type being cleared
too early. To catch this crash at the point of error, the plan is to
lock the animated property type of the result animation during
processing, and guard for clearing the animation property while the
lock is held (in clearAnimatedType()).

For SMILTimeContainer::updateAnimations() to have a chance of
unlocking the animated property _before_ clearAnimatedType() is
called, we need to move the call up to
SMILTimeContainer::updateAnimations(). (The assumption is that moving
the call shouldn't make a difference since
SMILTimeContainer::updateAnimations() is the only call-site for
SVGSMILElement::progress() and the intermediate code shouldn't depend
on the animated property.)

Since the clearing of property type and nullifying of resultElement
seems tied together, grouping them makes sense regardless of the crash
chase.

BUG=581546

Committed: https://crrev.com/8ac7017db3685604db2d79d8e667ba1d7cf463a2
Cr-Commit-Position: refs/heads/master@{#394698}
==========

[commit-bot: I haz the power, 2016-05-19 06:37:16]

Patchset 1 (id:??) landed as
https://crrev.com/8ac7017db3685604db2d79d8e667ba1d7cf463a2
Cr-Commit-Position: refs/heads/master@{#394698}