Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp

Issue 1989033003: Move clearAnimatedType() up the stack (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 463 matching lines...) Expand 10 before | Expand all | Expand 10 after
474 SVGSMILElement* animation = itAnimation.get(); 474 SVGSMILElement* animation = itAnimation.get();
475 ASSERT(animation->timeContainer() == this); 475 ASSERT(animation->timeContainer() == this);
476 ASSERT(animation->targetElement()); 476 ASSERT(animation->targetElement());
477 ASSERT(animation->hasValidAttributeName()); 477 ASSERT(animation->hasValidAttributeName());
478 ASSERT(animation->hasValidAttributeType()); 478 ASSERT(animation->hasValidAttributeType());
479 479
480 // Results are accumulated to the first animation that animates and contributes to a particular element/attribute pair. 480 // Results are accumulated to the first animation that animates and contributes to a particular element/attribute pair.
481 if (!resultElement) 481 if (!resultElement)
482 resultElement = animation; 482 resultElement = animation;
483 483
484 // This will calculate the contribution from the animation and add i t to the resultsElement. 484 // This will calculate the contribution from the animation and add i t to the resultElement.
485 if (!animation->progress(elapsed, resultElement, seekToTime) && resu ltElement == animation) 485 if (!animation->progress(elapsed, resultElement, seekToTime) && resu ltElement == animation) {
486 resultElement->clearAnimatedType();
486 resultElement = nullptr; 487 resultElement = nullptr;
488 }
487 489
488 SMILTime nextFireTime = animation->nextProgressTime(); 490 SMILTime nextFireTime = animation->nextProgressTime();
489 if (nextFireTime.isFinite()) 491 if (nextFireTime.isFinite())
490 earliestFireTime = std::min(nextFireTime, earliestFireTime); 492 earliestFireTime = std::min(nextFireTime, earliestFireTime);
491 } 493 }
492 494
493 if (resultElement) 495 if (resultElement)
494 animationsToApply.append(resultElement); 496 animationsToApply.append(resultElement);
495 } 497 }
496 m_scheduledAnimations.removeAll(invalidKeys); 498 m_scheduledAnimations.removeAll(invalidKeys);
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
536 setElapsed(elapsed().value() + initialFrameDelay); 538 setElapsed(elapsed().value() + initialFrameDelay);
537 } 539 }
538 540
539 DEFINE_TRACE(SMILTimeContainer) 541 DEFINE_TRACE(SMILTimeContainer)
540 { 542 {
541 visitor->trace(m_scheduledAnimations); 543 visitor->trace(m_scheduledAnimations);
542 visitor->trace(m_ownerSVGElement); 544 visitor->trace(m_ownerSVGElement);
543 } 545 }
544 546
545 } // namespace blink 547 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698