Added Vulkan Descriptor Sets and Samplers.

Added Vulkan Descriptor Sets and Samplers.

R=piman@chromium.org
BUG=582558
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/f75239bf238c5d5f13a92fef41ae9ac2aec5685d
Cr-Commit-Position: refs/heads/master@{#394586}

[David Yen, 2016-05-18 00:06:16]

Description was changed from

==========
Added Vulkan Descriptor Sets and Samplers.

R=piman@chromium.org
BUG=582558
==========

to

==========
Added Vulkan Descriptor Sets and Samplers.

R=piman@chromium.org
BUG=582558
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[piman, 2016-05-18 19:02:18]

https://codereview.chromium.org/1989013002/diff/1/gpu/vulkan/vulkan_descripto...
File gpu/vulkan/vulkan_descriptor_pool.cc (right):

https://codereview.chromium.org/1989013002/diff/1/gpu/vulkan/vulkan_descripto...
gpu/vulkan/vulkan_descriptor_pool.cc:57: descriptor_count_ = 0;
nit: it's already 0 (see DCHECK)

https://codereview.chromium.org/1989013002/diff/1/gpu/vulkan/vulkan_descripto...
File gpu/vulkan/vulkan_descriptor_set.cc (right):

https://codereview.chromium.org/1989013002/diff/1/gpu/vulkan/vulkan_descripto...
gpu/vulkan/vulkan_descriptor_set.cc:31: &layout_);
I think we'll want to separate out the DescriptorSetLayout, that we'll need for
the PipelineLayouts (for the Pipelines themselves). DescriptorSetLayout is a bit
like a template, and we'll need several instances of DescriptorSets using the
same exact layout (e.g. to handle different data across different instances, or
different frames).

https://codereview.chromium.org/1989013002/diff/1/gpu/vulkan/vulkan_sampler.h
File gpu/vulkan/vulkan_sampler.h (right):

https://codereview.chromium.org/1989013002/diff/1/gpu/vulkan/vulkan_sampler.h...
gpu/vulkan/vulkan_sampler.h:32: float max_anisotropy = 0.0f;
nit: 1.0f (values < 1.0f don't really make sense)

[David Yen, 2016-05-18 21:08:35]

https://codereview.chromium.org/1989013002/diff/1/gpu/vulkan/vulkan_descripto...
File gpu/vulkan/vulkan_descriptor_pool.cc (right):

https://codereview.chromium.org/1989013002/diff/1/gpu/vulkan/vulkan_descripto...
gpu/vulkan/vulkan_descriptor_pool.cc:57: descriptor_count_ = 0;
On 2016/05/18 19:02:18, piman wrote:
> nit: it's already 0 (see DCHECK)

Done.

https://codereview.chromium.org/1989013002/diff/1/gpu/vulkan/vulkan_descripto...
File gpu/vulkan/vulkan_descriptor_set.cc (right):

https://codereview.chromium.org/1989013002/diff/1/gpu/vulkan/vulkan_descripto...
gpu/vulkan/vulkan_descriptor_set.cc:31: &layout_);
On 2016/05/18 19:02:18, piman wrote:
> I think we'll want to separate out the DescriptorSetLayout, that we'll need
for
> the PipelineLayouts (for the Pipelines themselves). DescriptorSetLayout is a
bit
> like a template, and we'll need several instances of DescriptorSets using the
> same exact layout (e.g. to handle different data across different instances,
or
> different frames).

Done.

https://codereview.chromium.org/1989013002/diff/1/gpu/vulkan/vulkan_sampler.h
File gpu/vulkan/vulkan_sampler.h (right):

https://codereview.chromium.org/1989013002/diff/1/gpu/vulkan/vulkan_sampler.h...
gpu/vulkan/vulkan_sampler.h:32: float max_anisotropy = 0.0f;
On 2016/05/18 19:02:18, piman wrote:
> nit: 1.0f (values < 1.0f don't really make sense)

Done.

[piman, 2016-05-18 21:26:32]

lgtm

[David Yen, 2016-05-18 21:27:39]

The CQ bit was checked by dyen@chromium.org

[commit-bot: I haz the power, 2016-05-18 21:28:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1989013002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1989013002/20001

[commit-bot: I haz the power, 2016-05-18 23:04:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-18 23:05:45]

Description was changed from

==========
Added Vulkan Descriptor Sets and Samplers.

R=piman@chromium.org
BUG=582558
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Added Vulkan Descriptor Sets and Samplers.

R=piman@chromium.org
BUG=582558
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/f75239bf238c5d5f13a92fef41ae9ac2aec5685d
Cr-Commit-Position: refs/heads/master@{#394586}
==========

[commit-bot: I haz the power, 2016-05-18 23:05:47]

Patchset 2 (id:??) landed as
https://crrev.com/f75239bf238c5d5f13a92fef41ae9ac2aec5685d
Cr-Commit-Position: refs/heads/master@{#394586}