[Offline pages] Moving disk size related calls to Archive Manager, reorganizing UMA

components/offline_pages/archive_manager.h

Index: components/offline_pages/archive_manager.h
diff --git a/components/offline_pages/archive_manager.h b/components/offline_pages/archive_manager.h
index 6441d85fdc82ffe85c3641bd0e1037883d728bbf..7220042d00ad1bcbc1b858ac5cbf25fda883868c 100644
--- a/components/offline_pages/archive_manager.h
+++ b/components/offline_pages/archive_manager.h
@@ -23,6 +23,13 @@ namespace offline_pages {
 // All tasks are performed using |task_runner_|.
 class ArchiveManager {
  public:
+  // Structure for passing around information related to disk space consumed by

[jianli, 2016/05/18 00:06:00]

nit: no need to comment since struct name should be clear

[fgorski, 2016/05/18 18:14:59]

Done.

+  // offline page archives.
+  struct StorageSizes {

[jianli, 2016/05/18 00:05:59]

nit: StorageStats

[fgorski, 2016/05/18 18:14:59]

Done.

+    int64_t free_disk_space;
+    int64_t total_archives_size;
+  };
+
   ArchiveManager(const base::FilePath& archives_dir,
                  const scoped_refptr<base::SequencedTaskRunner>& task_runner);
   virtual ~ArchiveManager();
@@ -52,6 +59,11 @@ class ArchiveManager {
       const base::Callback<void(const std::set<base::FilePath>&)>& callback)
       const;
 
+  // Gets information about disk space consumed by offline archives and disk
+  // space available, for UMA reporting.

[jianli, 2016/05/18 00:06:00]

nit: remove UMA reporting in case we might use this info for other purpose

// Gets stats about archive storage, i.e., total archive sizes and free disk
space.

[fgorski, 2016/05/18 18:14:59]

Done.

+  virtual void GetStorageSizes(

[jianli, 2016/05/18 00:05:59]

nit: GetStorageStats

[fgorski, 2016/05/18 18:14:59]

Done.

+      const base::Callback<void(StorageSizes storage_sizes)>& callback) const;
+
  private:
   // Path under which all of the managed archives should be stored.
   base::FilePath archives_dir_;