chrome/browser/android/offline_pages/offline_page_bridge.cc - Issue 1988973002: [Offline pages] Moving disk size related calls to Archive Manager, reorganizing UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_bridge.cc

Issue 1988973002: [Offline pages] Moving disk size related calls to Archive Manager, reorganizing UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@archive-manager

Patch Set: Adding test, updating ArchiveManager implementation to task runner. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_bridge.h ('k') | components/offline_pages/archive_manager.h » ('j') | components/offline_pages/archive_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/offline_page_bridge.cc

diff --git a/chrome/browser/android/offline_pages/offline_page_bridge.cc b/chrome/browser/android/offline_pages/offline_page_bridge.cc

index ee2bd0bfd7756f312df209ec5a7c7f2112d0362b..adf51418b7f323a5fc366db1f7d8661f5af3f5dd 100644

--- a/chrome/browser/android/offline_pages/offline_page_bridge.cc

+++ b/chrome/browser/android/offline_pages/offline_page_bridge.cc

@@ -361,16 +361,6 @@ void OfflinePageBridge::CheckMetadataConsistency(

offline_page_model_->CheckForExternalFileDeletion();

}

-void OfflinePageBridge::RecordStorageHistograms(

- JNIEnv* env,

- const JavaParamRef<jobject>& obj,

- jlong total_space_bytes,

- jlong free_space_bytes,

- jboolean reporting_after_delete) {

- offline_page_model_->RecordStorageHistograms(

- total_space_bytes, free_space_bytes, reporting_after_delete);

void OfflinePageBridge::NotifyIfDoneLoading() const {

if (!offline_page_model_->is_loaded())

return;