[ios Mojo] Mojo resources.

[ios Mojo] Mojo resources.

Adds Mojo JavaScript files to web resources. Same JS files are part of
content resources and web mirrors that. This CL is a part of Mojo WebUI
implementation.

Design doc:
https://docs.google.com/document/d/1iUJXX_zoY2BbnecpfxjznOeasf29KUzl_9S_LG08Bes/edit#heading=h.yjqp5garsqf9

BUG=567809
Committed: https://crrev.com/395c54ea3c6a98523b6765310f09f1c69708e731
Cr-Commit-Position: refs/heads/master@{#394899}

[Eugene But (OOO till 7-30), 2016-05-17 16:47:46]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 16:48:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988863002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988863002/1

[commit-bot: I haz the power, 2016-05-17 16:53:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 16:53:59]

Dry run: Try jobs failed on following builders:
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)

[Eugene But (OOO till 7-30), 2016-05-17 20:18:31]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 20:19:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988863002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988863002/20001

[Eugene But (OOO till 7-30), 2016-05-17 22:57:07]

eugenebut@chromium.org changed reviewers:
+ jyquinn@chromium.org, rockot@chromium.org

[Jackie Quinn, 2016-05-19 15:10:17]

lgtm with TODO question.

https://codereview.chromium.org/1988863002/diff/40001/ios/web/ios_web_resourc...
File ios/web/ios_web_resources.gyp (right):

https://codereview.chromium.org/1988863002/diff/40001/ios/web/ios_web_resourc...
ios/web/ios_web_resources.gyp:9: # TODO(eugenebut): Add gn version.
GN mods above - is this now irrelevant?

[Eugene But (OOO till 7-30), 2016-05-19 15:15:33]

https://codereview.chromium.org/1988863002/diff/40001/ios/web/ios_web_resourc...
File ios/web/ios_web_resources.gyp (right):

https://codereview.chromium.org/1988863002/diff/40001/ios/web/ios_web_resourc...
ios/web/ios_web_resources.gyp:9: # TODO(eugenebut): Add gn version.
On 2016/05/19 15:10:17, Jackie Quinn wrote:
> GN mods above - is this now irrelevant?
Thanks, removed.

[Ken Rockot(use gerrit already), 2016-05-19 15:21:48]

lgtm

[Eugene But (OOO till 7-30), 2016-05-19 15:28:32]

eugenebut@chromium.org changed reviewers:
+ thestig@chromium.org

[Eugene But (OOO till 7-30), 2016-05-19 15:28:33]

thestig@ for tools/grit OWNERS

[Lei Zhang, 2016-05-19 17:17:29]

https://codereview.chromium.org/1988863002/diff/80001/tools/gritsettings/reso...
File tools/gritsettings/resource_ids (right):

https://codereview.chromium.org/1988863002/diff/80001/tools/gritsettings/reso...
tools/gritsettings/resource_ids:308: "ios/web/ios_web_resources.grd": {
Does iOS use content/content_resources.grd at all? If not, consider reusing
those IDs rather than using whatever little space there is here. (See comment
below)

Someone was looking at this problem but I have no idea if any progress has been
made.

[Eugene But (OOO till 7-30), 2016-05-19 18:55:57]

https://codereview.chromium.org/1988863002/diff/80001/tools/gritsettings/reso...
File tools/gritsettings/resource_ids (right):

https://codereview.chromium.org/1988863002/diff/80001/tools/gritsettings/reso...
tools/gritsettings/resource_ids:308: "ios/web/ios_web_resources.grd": {
On 2016/05/19 17:17:29, Lei Zhang wrote:
> Does iOS use content/content_resources.grd at all? If not, consider reusing
> those IDs rather than using whatever little space there is here. (See comment
> below)
> 
> Someone was looking at this problem but I have no idea if any progress has
been
> made.
iOS does not use anything from content, which is done on purpose (content is a
library built on top of Blink and iOS is not allowed to use Blink). Could you
please be more specific what do you mean by reusing IDs. Do you mean
s/30960/4700 for includes? That does not feel very maintainable.

[Lei Zhang, 2016-05-19 19:03:02]

https://codereview.chromium.org/1988863002/diff/80001/tools/gritsettings/reso...
File tools/gritsettings/resource_ids (right):

https://codereview.chromium.org/1988863002/diff/80001/tools/gritsettings/reso...
tools/gritsettings/resource_ids:308: "ios/web/ios_web_resources.grd": {
On 2016/05/19 18:55:57, Eugene But wrote:
> On 2016/05/19 17:17:29, Lei Zhang wrote:
> > Does iOS use content/content_resources.grd at all? If not, consider reusing
> > those IDs rather than using whatever little space there is here. (See
comment
> > below)
> > 
> > Someone was looking at this problem but I have no idea if any progress has
> been
> > made.
> iOS does not use anything from content, which is done on purpose (content is a
> library built on top of Blink and iOS is not allowed to use Blink). Could you
> please be more specific what do you mean by reusing IDs. Do you mean
> s/30960/4700 for includes? That does not feel very maintainable.

- put this after line 175
- reuse 23950
- add a comment like the one on line 280 to explain the overlap

[Lei Zhang, 2016-05-19 19:06:26]

FWIW, the ID space out of room bug is
https://bugs.chromium.org/p/chromium/issues/detail?id=585301

[Eugene But (OOO till 7-30), 2016-05-19 20:58:33]

PTAL

https://codereview.chromium.org/1988863002/diff/80001/tools/gritsettings/reso...
File tools/gritsettings/resource_ids (right):

https://codereview.chromium.org/1988863002/diff/80001/tools/gritsettings/reso...
tools/gritsettings/resource_ids:308: "ios/web/ios_web_resources.grd": {
On 2016/05/19 19:03:02, Lei Zhang wrote:
> On 2016/05/19 18:55:57, Eugene But wrote:
> > On 2016/05/19 17:17:29, Lei Zhang wrote:
> > > Does iOS use content/content_resources.grd at all? If not, consider
reusing
> > > those IDs rather than using whatever little space there is here. (See
> comment
> > > below)
> > > 
> > > Someone was looking at this problem but I have no idea if any progress has
> > been
> > > made.
> > iOS does not use anything from content, which is done on purpose (content is
a
> > library built on top of Blink and iOS is not allowed to use Blink). Could
you
> > please be more specific what do you mean by reusing IDs. Do you mean
> > s/30960/4700 for includes? That does not feel very maintainable.
> 
> - put this after line 175
> - reuse 23950
> - add a comment like the one on line 280 to explain the overlap
Thanks you for very detailed instructions. Done.

[Lei Zhang, 2016-05-19 21:02:34]

lgtm, thanks for putting up with this silly ID space issue.

[Eugene But (OOO till 7-30), 2016-05-19 21:36:04]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-05-19 21:36:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
jyquinn@chromium.org, rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/1988863002/#ps120001
(title: "Self review")

[commit-bot: I haz the power, 2016-05-19 21:37:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988863002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988863002/120001

[commit-bot: I haz the power, 2016-05-19 23:17:09]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-05-19 23:19:20]

Description was changed from

==========
[ios Mojo] Mojo resources.

Adds Mojo JavaScript files to web resources. Same JS files are part of
content resources and web mirrors that. This CL is a part of Mojo WebUI
implementation.

Design doc:
https://docs.google.com/document/d/1iUJXX_zoY2BbnecpfxjznOeasf29KUzl_9S_LG08B...

BUG=567809
==========

to

==========
[ios Mojo] Mojo resources.

Adds Mojo JavaScript files to web resources. Same JS files are part of
content resources and web mirrors that. This CL is a part of Mojo WebUI
implementation.

Design doc:
https://docs.google.com/document/d/1iUJXX_zoY2BbnecpfxjznOeasf29KUzl_9S_LG08B...

BUG=567809

Committed: https://crrev.com/395c54ea3c6a98523b6765310f09f1c69708e731
Cr-Commit-Position: refs/heads/master@{#394899}
==========

[commit-bot: I haz the power, 2016-05-19 23:19:21]

Patchset 7 (id:??) landed as
https://crrev.com/395c54ea3c6a98523b6765310f09f1c69708e731
Cr-Commit-Position: refs/heads/master@{#394899}