tools/gritsettings/resource_ids - Issue 1988863002: [ios Mojo] Mojo resources.

Side by Side Diff: tools/gritsettings/resource_ids

Issue 1988863002: [ios Mojo] Mojo resources. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed TODO Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4 #	4 #

5 # This file is used to assign starting resource ids for resources and strings	5 # This file is used to assign starting resource ids for resources and strings

6 # used by Chromium. This is done to ensure that resource ids are unique	6 # used by Chromium. This is done to ensure that resource ids are unique

7 # across all the grd files. If you are adding a new grd file, please add	7 # across all the grd files. If you are adding a new grd file, please add

8 # a new entry to this file.	8 # a new entry to this file.

9 #	9 #

10 # The first entry in the file, SRCDIR, is special: It is a relative path from	10 # The first entry in the file, SRCDIR, is special: It is a relative path from

(...skipping 287 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
298 },	298 },

299 "chrome/browser/resources/md_policy/policy_resources.grd": {	299 "chrome/browser/resources/md_policy/policy_resources.grd": {

300 "structures": [30900],	300 "structures": [30900],

301 },	301 },

302 "chrome/browser/resources/settings/settings_resources.grd": {	302 "chrome/browser/resources/settings/settings_resources.grd": {

303 "structures": [30920],	303 "structures": [30920],

304 },	304 },

305 "headless/lib/resources/headless_lib_resources.grd": {	305 "headless/lib/resources/headless_lib_resources.grd": {

306 "includes": [30940],	306 "includes": [30940],

307 },	307 },

	308 "ios/web/ios_web_resources.grd": {
	Lei Zhang 2016/05/19 17:17:29 Does iOS use content/content_resources.grd at all? Does iOS use content/content_resources.grd at all? If not, consider reusing those IDs rather than using whatever little space there is here. (See comment below) Someone was looking at this problem but I have no idea if any progress has been made. Eugene But (OOO till 7-30) 2016/05/19 18:55:57 iOS does not use anything from content, which is d Show quoted text On 2016/05/19 17:17:29, Lei Zhang wrote: > Does iOS use content/content_resources.grd at all? If not, consider reusing > those IDs rather than using whatever little space there is here. (See comment > below) > > Someone was looking at this problem but I have no idea if any progress has been > made. iOS does not use anything from content, which is done on purpose (content is a library built on top of Blink and iOS is not allowed to use Blink). Could you please be more specific what do you mean by reusing IDs. Do you mean s/30960/4700 for includes? That does not feel very maintainable. Lei Zhang 2016/05/19 19:03:02 - put this after line 175 - reuse 23950 - add a co Show quoted text On 2016/05/19 18:55:57, Eugene But wrote: > On 2016/05/19 17:17:29, Lei Zhang wrote: > > Does iOS use content/content_resources.grd at all? If not, consider reusing > > those IDs rather than using whatever little space there is here. (See comment > > below) > > > > Someone was looking at this problem but I have no idea if any progress has > been > > made. > iOS does not use anything from content, which is done on purpose (content is a > library built on top of Blink and iOS is not allowed to use Blink). Could you > please be more specific what do you mean by reusing IDs. Do you mean > s/30960/4700 for includes? That does not feel very maintainable. - put this after line 175 - reuse 23950 - add a comment like the one on line 280 to explain the overlap Eugene But (OOO till 7-30) 2016/05/19 20:58:33 Thanks you for very detailed instructions. Done. Show quoted text On 2016/05/19 19:03:02, Lei Zhang wrote: > On 2016/05/19 18:55:57, Eugene But wrote: > > On 2016/05/19 17:17:29, Lei Zhang wrote: > > > Does iOS use content/content_resources.grd at all? If not, consider reusing > > > those IDs rather than using whatever little space there is here. (See > comment > > > below) > > > > > > Someone was looking at this problem but I have no idea if any progress has > > been > > > made. > > iOS does not use anything from content, which is done on purpose (content is a > > library built on top of Blink and iOS is not allowed to use Blink). Could you > > please be more specific what do you mean by reusing IDs. Do you mean > > s/30960/4700 for includes? That does not feel very maintainable. > > - put this after line 175 > - reuse 23950 > - add a comment like the one on line 280 to explain the overlap Thanks you for very detailed instructions. Done.
	309 "includes": [30960],

	310 },

308	311

309 # Resource ids starting at 31000 are reserved for projects built on Chromium.	312 # Resource ids starting at 31000 are reserved for projects built on Chromium.

310 }	313 }

OLD	NEW

« no previous file with comments | « ios/web/ios_web_resources.gyp ('k') | no next file » | no next file with comments »