Revert "Enable MD by default on Windows for Canary/Dev and local builds."

Revert "Enable MD by default on Windows for Canary/Dev and local builds."

This reverts commit 56100334b16d67730fef9918be5b0c1131dacad9 due to consistently hitting DCHECK:

[14259:14259:0517/110009:FATAL:browser_process_impl.cc(696)] Check failed: !locale_.empty().
#0 0x7fe8fff6782e base::debug::StackTrace::StackTrace()
#1 0x7fe8fffca0ff logging::LogMessage::~LogMessage()
#2 0x7fe900f61604 BrowserProcessImpl::GetApplicationLocale()
#3 0x7fe900fd077d ChromeVariationsServiceClient::GetApplicationLocale()
#4 0x7fe903156af3 variations::VariationsService::CreateTrialsFromSeed()
#5 0x7fe900c916f5 ChromeBrowserMainParts::SetupMetricsAndFieldTrials()
#6 0x7fe900c933bb ChromeBrowserMainParts::PreCreateThreadsImpl()
#7 0x7fe900c922c5 ChromeBrowserMainParts::PreCreateThreads()
#8 0x7fe8f9426064 content::BrowserMainLoop::PreCreateThreads()
(...)

BUG=609044
NOTRY=true
TBR=pkasting@chromium.org

Committed: https://crrev.com/28f8c7dc877a91d3ed12b9da6c802ab8bbe217ed
Cr-Commit-Position: refs/heads/master@{#394106}

[Henrik Grunell, 2016-05-17 12:20:47]

Description was changed from

==========
Revert "Enable MD by default on Windows for Canary/Dev and local builds."

This reverts commit 56100334b16d67730fef9918be5b0c1131dacad9 due to
hitting DCHECK:

[14259:14259:0517/110009:FATAL:browser_process_impl.cc(696)] Check failed:
!locale_.empty().
(...)

BUG=609044
==========

to

==========
Revert "Enable MD by default on Windows for Canary/Dev and local builds."

This reverts commit 56100334b16d67730fef9918be5b0c1131dacad9 due to
hitting DCHECK:

[14259:14259:0517/110009:FATAL:browser_process_impl.cc(696)] Check failed:
!locale_.empty().
#0 0x7fe8fff6782e base::debug::StackTrace::StackTrace()
#1 0x7fe8fffca0ff logging::LogMessage::~LogMessage()
#2 0x7fe900f61604 BrowserProcessImpl::GetApplicationLocale()
#3 0x7fe900fd077d ChromeVariationsServiceClient::GetApplicationLocale()
#4 0x7fe903156af3 variations::VariationsService::CreateTrialsFromSeed()
#5 0x7fe900c916f5 ChromeBrowserMainParts::SetupMetricsAndFieldTrials()
#6 0x7fe900c933bb ChromeBrowserMainParts::PreCreateThreadsImpl()
#7 0x7fe900c922c5 ChromeBrowserMainParts::PreCreateThreads()
#8 0x7fe8f9426064 content::BrowserMainLoop::PreCreateThreads()
(...)

BUG=609044
==========

[Henrik Grunell, 2016-05-17 12:20:47]

grunell@chromium.org changed reviewers:
+ pkasting@chromium.org

[Henrik Grunell, 2016-05-17 12:21:47]

Description was changed from

==========
Revert "Enable MD by default on Windows for Canary/Dev and local builds."

This reverts commit 56100334b16d67730fef9918be5b0c1131dacad9 due to
hitting DCHECK:

[14259:14259:0517/110009:FATAL:browser_process_impl.cc(696)] Check failed:
!locale_.empty().
#0 0x7fe8fff6782e base::debug::StackTrace::StackTrace()
#1 0x7fe8fffca0ff logging::LogMessage::~LogMessage()
#2 0x7fe900f61604 BrowserProcessImpl::GetApplicationLocale()
#3 0x7fe900fd077d ChromeVariationsServiceClient::GetApplicationLocale()
#4 0x7fe903156af3 variations::VariationsService::CreateTrialsFromSeed()
#5 0x7fe900c916f5 ChromeBrowserMainParts::SetupMetricsAndFieldTrials()
#6 0x7fe900c933bb ChromeBrowserMainParts::PreCreateThreadsImpl()
#7 0x7fe900c922c5 ChromeBrowserMainParts::PreCreateThreads()
#8 0x7fe8f9426064 content::BrowserMainLoop::PreCreateThreads()
(...)

BUG=609044
==========

to

==========
Revert "Enable MD by default on Windows for Canary/Dev and local builds."

This reverts commit 56100334b16d67730fef9918be5b0c1131dacad9 due to consistently
hitting DCHECK:

[14259:14259:0517/110009:FATAL:browser_process_impl.cc(696)] Check failed:
!locale_.empty().
#0 0x7fe8fff6782e base::debug::StackTrace::StackTrace()
#1 0x7fe8fffca0ff logging::LogMessage::~LogMessage()
#2 0x7fe900f61604 BrowserProcessImpl::GetApplicationLocale()
#3 0x7fe900fd077d ChromeVariationsServiceClient::GetApplicationLocale()
#4 0x7fe903156af3 variations::VariationsService::CreateTrialsFromSeed()
#5 0x7fe900c916f5 ChromeBrowserMainParts::SetupMetricsAndFieldTrials()
#6 0x7fe900c933bb ChromeBrowserMainParts::PreCreateThreadsImpl()
#7 0x7fe900c922c5 ChromeBrowserMainParts::PreCreateThreads()
#8 0x7fe8f9426064 content::BrowserMainLoop::PreCreateThreads()
(...)

BUG=609044
==========

[Henrik Grunell, 2016-05-17 12:22:13]

Description was changed from

==========
Revert "Enable MD by default on Windows for Canary/Dev and local builds."

This reverts commit 56100334b16d67730fef9918be5b0c1131dacad9 due to consistently
hitting DCHECK:

[14259:14259:0517/110009:FATAL:browser_process_impl.cc(696)] Check failed:
!locale_.empty().
#0 0x7fe8fff6782e base::debug::StackTrace::StackTrace()
#1 0x7fe8fffca0ff logging::LogMessage::~LogMessage()
#2 0x7fe900f61604 BrowserProcessImpl::GetApplicationLocale()
#3 0x7fe900fd077d ChromeVariationsServiceClient::GetApplicationLocale()
#4 0x7fe903156af3 variations::VariationsService::CreateTrialsFromSeed()
#5 0x7fe900c916f5 ChromeBrowserMainParts::SetupMetricsAndFieldTrials()
#6 0x7fe900c933bb ChromeBrowserMainParts::PreCreateThreadsImpl()
#7 0x7fe900c922c5 ChromeBrowserMainParts::PreCreateThreads()
#8 0x7fe8f9426064 content::BrowserMainLoop::PreCreateThreads()
(...)

BUG=609044
==========

to

==========
Revert "Enable MD by default on Windows for Canary/Dev and local builds."

This reverts commit 56100334b16d67730fef9918be5b0c1131dacad9 due to consistently
hitting DCHECK:

[14259:14259:0517/110009:FATAL:browser_process_impl.cc(696)] Check failed:
!locale_.empty().
#0 0x7fe8fff6782e base::debug::StackTrace::StackTrace()
#1 0x7fe8fffca0ff logging::LogMessage::~LogMessage()
#2 0x7fe900f61604 BrowserProcessImpl::GetApplicationLocale()
#3 0x7fe900fd077d ChromeVariationsServiceClient::GetApplicationLocale()
#4 0x7fe903156af3 variations::VariationsService::CreateTrialsFromSeed()
#5 0x7fe900c916f5 ChromeBrowserMainParts::SetupMetricsAndFieldTrials()
#6 0x7fe900c933bb ChromeBrowserMainParts::PreCreateThreadsImpl()
#7 0x7fe900c922c5 ChromeBrowserMainParts::PreCreateThreads()
#8 0x7fe8f9426064 content::BrowserMainLoop::PreCreateThreads()
(...)

BUG=609044
NOTRY=true
==========

[Henrik Grunell, 2016-05-17 12:22:21]

The CQ bit was checked by grunell@chromium.org

[commit-bot: I haz the power, 2016-05-17 12:22:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988733002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988733002/1

[commit-bot: I haz the power, 2016-05-17 12:22:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 12:22:32]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Henrik Grunell, 2016-05-17 12:23:16]

Description was changed from

==========
Revert "Enable MD by default on Windows for Canary/Dev and local builds."

This reverts commit 56100334b16d67730fef9918be5b0c1131dacad9 due to consistently
hitting DCHECK:

[14259:14259:0517/110009:FATAL:browser_process_impl.cc(696)] Check failed:
!locale_.empty().
#0 0x7fe8fff6782e base::debug::StackTrace::StackTrace()
#1 0x7fe8fffca0ff logging::LogMessage::~LogMessage()
#2 0x7fe900f61604 BrowserProcessImpl::GetApplicationLocale()
#3 0x7fe900fd077d ChromeVariationsServiceClient::GetApplicationLocale()
#4 0x7fe903156af3 variations::VariationsService::CreateTrialsFromSeed()
#5 0x7fe900c916f5 ChromeBrowserMainParts::SetupMetricsAndFieldTrials()
#6 0x7fe900c933bb ChromeBrowserMainParts::PreCreateThreadsImpl()
#7 0x7fe900c922c5 ChromeBrowserMainParts::PreCreateThreads()
#8 0x7fe8f9426064 content::BrowserMainLoop::PreCreateThreads()
(...)

BUG=609044
NOTRY=true
==========

to

==========
Revert "Enable MD by default on Windows for Canary/Dev and local builds."

This reverts commit 56100334b16d67730fef9918be5b0c1131dacad9 due to consistently
hitting DCHECK:

[14259:14259:0517/110009:FATAL:browser_process_impl.cc(696)] Check failed:
!locale_.empty().
#0 0x7fe8fff6782e base::debug::StackTrace::StackTrace()
#1 0x7fe8fffca0ff logging::LogMessage::~LogMessage()
#2 0x7fe900f61604 BrowserProcessImpl::GetApplicationLocale()
#3 0x7fe900fd077d ChromeVariationsServiceClient::GetApplicationLocale()
#4 0x7fe903156af3 variations::VariationsService::CreateTrialsFromSeed()
#5 0x7fe900c916f5 ChromeBrowserMainParts::SetupMetricsAndFieldTrials()
#6 0x7fe900c933bb ChromeBrowserMainParts::PreCreateThreadsImpl()
#7 0x7fe900c922c5 ChromeBrowserMainParts::PreCreateThreads()
#8 0x7fe8f9426064 content::BrowserMainLoop::PreCreateThreads()
(...)

BUG=609044
NOTRY=true
TBR=pkasting@chromium.org
==========

[Henrik Grunell, 2016-05-17 12:23:21]

The CQ bit was checked by grunell@chromium.org

[commit-bot: I haz the power, 2016-05-17 12:23:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988733002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988733002/1

[commit-bot: I haz the power, 2016-05-17 12:30:12]

Description was changed from

==========
Revert "Enable MD by default on Windows for Canary/Dev and local builds."

This reverts commit 56100334b16d67730fef9918be5b0c1131dacad9 due to consistently
hitting DCHECK:

[14259:14259:0517/110009:FATAL:browser_process_impl.cc(696)] Check failed:
!locale_.empty().
#0 0x7fe8fff6782e base::debug::StackTrace::StackTrace()
#1 0x7fe8fffca0ff logging::LogMessage::~LogMessage()
#2 0x7fe900f61604 BrowserProcessImpl::GetApplicationLocale()
#3 0x7fe900fd077d ChromeVariationsServiceClient::GetApplicationLocale()
#4 0x7fe903156af3 variations::VariationsService::CreateTrialsFromSeed()
#5 0x7fe900c916f5 ChromeBrowserMainParts::SetupMetricsAndFieldTrials()
#6 0x7fe900c933bb ChromeBrowserMainParts::PreCreateThreadsImpl()
#7 0x7fe900c922c5 ChromeBrowserMainParts::PreCreateThreads()
#8 0x7fe8f9426064 content::BrowserMainLoop::PreCreateThreads()
(...)

BUG=609044
NOTRY=true
TBR=pkasting@chromium.org
==========

to

==========
Revert "Enable MD by default on Windows for Canary/Dev and local builds."

This reverts commit 56100334b16d67730fef9918be5b0c1131dacad9 due to consistently
hitting DCHECK:

[14259:14259:0517/110009:FATAL:browser_process_impl.cc(696)] Check failed:
!locale_.empty().
#0 0x7fe8fff6782e base::debug::StackTrace::StackTrace()
#1 0x7fe8fffca0ff logging::LogMessage::~LogMessage()
#2 0x7fe900f61604 BrowserProcessImpl::GetApplicationLocale()
#3 0x7fe900fd077d ChromeVariationsServiceClient::GetApplicationLocale()
#4 0x7fe903156af3 variations::VariationsService::CreateTrialsFromSeed()
#5 0x7fe900c916f5 ChromeBrowserMainParts::SetupMetricsAndFieldTrials()
#6 0x7fe900c933bb ChromeBrowserMainParts::PreCreateThreadsImpl()
#7 0x7fe900c922c5 ChromeBrowserMainParts::PreCreateThreads()
#8 0x7fe8f9426064 content::BrowserMainLoop::PreCreateThreads()
(...)

BUG=609044
NOTRY=true
TBR=pkasting@chromium.org
==========

[commit-bot: I haz the power, 2016-05-17 12:30:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-17 12:31:31]

Description was changed from

==========
Revert "Enable MD by default on Windows for Canary/Dev and local builds."

This reverts commit 56100334b16d67730fef9918be5b0c1131dacad9 due to consistently
hitting DCHECK:

[14259:14259:0517/110009:FATAL:browser_process_impl.cc(696)] Check failed:
!locale_.empty().
#0 0x7fe8fff6782e base::debug::StackTrace::StackTrace()
#1 0x7fe8fffca0ff logging::LogMessage::~LogMessage()
#2 0x7fe900f61604 BrowserProcessImpl::GetApplicationLocale()
#3 0x7fe900fd077d ChromeVariationsServiceClient::GetApplicationLocale()
#4 0x7fe903156af3 variations::VariationsService::CreateTrialsFromSeed()
#5 0x7fe900c916f5 ChromeBrowserMainParts::SetupMetricsAndFieldTrials()
#6 0x7fe900c933bb ChromeBrowserMainParts::PreCreateThreadsImpl()
#7 0x7fe900c922c5 ChromeBrowserMainParts::PreCreateThreads()
#8 0x7fe8f9426064 content::BrowserMainLoop::PreCreateThreads()
(...)

BUG=609044
NOTRY=true
TBR=pkasting@chromium.org
==========

to

==========
Revert "Enable MD by default on Windows for Canary/Dev and local builds."

This reverts commit 56100334b16d67730fef9918be5b0c1131dacad9 due to consistently
hitting DCHECK:

[14259:14259:0517/110009:FATAL:browser_process_impl.cc(696)] Check failed:
!locale_.empty().
#0 0x7fe8fff6782e base::debug::StackTrace::StackTrace()
#1 0x7fe8fffca0ff logging::LogMessage::~LogMessage()
#2 0x7fe900f61604 BrowserProcessImpl::GetApplicationLocale()
#3 0x7fe900fd077d ChromeVariationsServiceClient::GetApplicationLocale()
#4 0x7fe903156af3 variations::VariationsService::CreateTrialsFromSeed()
#5 0x7fe900c916f5 ChromeBrowserMainParts::SetupMetricsAndFieldTrials()
#6 0x7fe900c933bb ChromeBrowserMainParts::PreCreateThreadsImpl()
#7 0x7fe900c922c5 ChromeBrowserMainParts::PreCreateThreads()
#8 0x7fe8f9426064 content::BrowserMainLoop::PreCreateThreads()
(...)

BUG=609044
NOTRY=true
TBR=pkasting@chromium.org

Committed: https://crrev.com/28f8c7dc877a91d3ed12b9da6c802ab8bbe217ed
Cr-Commit-Position: refs/heads/master@{#394106}
==========

[commit-bot: I haz the power, 2016-05-17 12:31:32]

Patchset 1 (id:??) landed as
https://crrev.com/28f8c7dc877a91d3ed12b9da6c802ab8bbe217ed
Cr-Commit-Position: refs/heads/master@{#394106}

[Henrik Grunell, 2016-05-17 12:34:35]

I hit this on Linux.