Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: ui/base/material_design/material_design_controller_unittest.cc

Issue 1988733002: Revert "Enable MD by default on Windows for Canary/Dev and local builds." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/material_design/material_design_controller.cc ('k') | ui/base/resource/resource_bundle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/material_design/material_design_controller_unittest.cc
diff --git a/ui/base/material_design/material_design_controller_unittest.cc b/ui/base/material_design/material_design_controller_unittest.cc
index dfea5ed1be1122815ca0cf357b35a6827e7ce217..b86820d89c7174d03ff858e852e7435ed45a9d04 100644
--- a/ui/base/material_design/material_design_controller_unittest.cc
+++ b/ui/base/material_design/material_design_controller_unittest.cc
@@ -24,9 +24,7 @@ class MaterialDesignControllerTest : public testing::Test {
// testing::Test:
void SetUp() override;
void TearDown() override;
-
void SetCommandLineSwitch(const std::string& value_string);
- bool CurrentModeIsDefaultMode();
private:
DISALLOW_COPY_AND_ASSIGN(MaterialDesignControllerTest);
@@ -56,11 +54,6 @@ void MaterialDesignControllerTest::SetCommandLineSwitch(
#endif // defined(ENABLE_TOPCHROME_MD)
}
-bool MaterialDesignControllerTest::CurrentModeIsDefaultMode() {
- return MaterialDesignController::GetMode() ==
- test::MaterialDesignControllerTestAPI::DefaultMode();
-}
-
class MaterialDesignControllerTestMaterial :
public MaterialDesignControllerTest {
public:
@@ -139,7 +132,8 @@ TEST_F(
TEST_F(
MaterialDesignControllerTestDefault,
DisabledCommandLineValueMapsToNonMaterialModeWhenCompileTimeFlagEnabled) {
- EXPECT_TRUE(CurrentModeIsDefaultMode());
+ EXPECT_EQ(MaterialDesignController::DefaultMode(),
+ MaterialDesignController::GetMode());
}
// Verify the current mode is reported as the default mode when no command line
@@ -148,12 +142,14 @@ TEST_F(MaterialDesignControllerTest,
NoCommandLineValueMapsToNonMaterialModeWhenCompileTimeFlagEnabled) {
ASSERT_FALSE(base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kTopChromeMD));
- EXPECT_TRUE(CurrentModeIsDefaultMode());
+ EXPECT_EQ(MaterialDesignController::DefaultMode(),
+ MaterialDesignController::GetMode());
}
// Verify an invalid command line value uses the default mode.
TEST_F(MaterialDesignControllerTestInvalid, InvalidCommandLineValue) {
- EXPECT_TRUE(CurrentModeIsDefaultMode());
+ EXPECT_EQ(MaterialDesignController::DefaultMode(),
+ MaterialDesignController::GetMode());
}
// Verify that MaterialDesignController::IsModeMaterial() will be true when
« no previous file with comments | « ui/base/material_design/material_design_controller.cc ('k') | ui/base/resource/resource_bundle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698