|
|
Created:
4 years, 7 months ago by shans Modified:
4 years, 7 months ago CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, asvitkine+watch_chromium.org, darktears, blink-reviews, rwlbuis Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionBetter counting of /deep/ usage
Better counting of /deep/ usage. The new counter will only trigger when /deep/ does
something different to the standard descendant combinator.
BUG=489954
Committed: https://crrev.com/1b0aab34b5ef9e168f1627703da1cc07c092ab62
Cr-Commit-Position: refs/heads/master@{#394640}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #
Messages
Total messages: 32 (17 generated)
shanestephens@google.com changed reviewers: + shanestephens@google.com, timloh@chromium.org
Description was changed from ========== Better counting of /deep/ usage. The new counter will only trigger when /deep/ does something different to the standard descendant combinator. BUG=489954 ========== to ========== Better counting of /deep/ usage. Better counting of /deep/ usage. The new counter will only trigger when /deep/ does something different to the standard descendant combinator. BUG=489954 ==========
Description was changed from ========== Better counting of /deep/ usage. Better counting of /deep/ usage. The new counter will only trigger when /deep/ does something different to the standard descendant combinator. BUG=489954 ========== to ========== Better counting of /deep/ usage Better counting of /deep/ usage. The new counter will only trigger when /deep/ does something different to the standard descendant combinator. BUG=489954 ==========
lgtm
shanestephens@google.com changed reviewers: + isherman@chromium.org
histograms.xml lgtm
The CQ bit was checked by shans@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988543002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by shans@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org, isherman@chromium.org Link to the patchset: https://codereview.chromium.org/1988543002/#ps20001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988543002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by shans@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988543002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by shans@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988543002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for third_party/WebKit/Source/core/frame/UseCounter.h: While running git apply --index -3 -p1; error: patch failed: third_party/WebKit/Source/core/frame/UseCounter.h:1182 Falling back to three-way merge... Applied patch to 'third_party/WebKit/Source/core/frame/UseCounter.h' with conflicts. U third_party/WebKit/Source/core/frame/UseCounter.h Patch: third_party/WebKit/Source/core/frame/UseCounter.h Index: third_party/WebKit/Source/core/frame/UseCounter.h diff --git a/third_party/WebKit/Source/core/frame/UseCounter.h b/third_party/WebKit/Source/core/frame/UseCounter.h index ce7450914180e686c29f8f342f705e63ac26ee8e..20e8ce550fc38b20258add03647201cd5953f35d 100644 --- a/third_party/WebKit/Source/core/frame/UseCounter.h +++ b/third_party/WebKit/Source/core/frame/UseCounter.h @@ -1182,6 +1182,7 @@ public: AudioListenerSetPosition = 1366, AudioListenerSetOrientation = 1367, IntersectionObserver_Constructor = 1368, + CSSDeepCombinatorAndShadow = 1369, // Add new features immediately above this line. Don't change assigned // numbers of any item, and don't reuse removed slots.
The CQ bit was checked by shans@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org, isherman@chromium.org Link to the patchset: https://codereview.chromium.org/1988543002/#ps40001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988543002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988543002/40001
Message was sent while issue was closed.
Description was changed from ========== Better counting of /deep/ usage Better counting of /deep/ usage. The new counter will only trigger when /deep/ does something different to the standard descendant combinator. BUG=489954 ========== to ========== Better counting of /deep/ usage Better counting of /deep/ usage. The new counter will only trigger when /deep/ does something different to the standard descendant combinator. BUG=489954 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Better counting of /deep/ usage Better counting of /deep/ usage. The new counter will only trigger when /deep/ does something different to the standard descendant combinator. BUG=489954 ========== to ========== Better counting of /deep/ usage Better counting of /deep/ usage. The new counter will only trigger when /deep/ does something different to the standard descendant combinator. BUG=489954 Committed: https://crrev.com/1b0aab34b5ef9e168f1627703da1cc07c092ab62 Cr-Commit-Position: refs/heads/master@{#394640} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/1b0aab34b5ef9e168f1627703da1cc07c092ab62 Cr-Commit-Position: refs/heads/master@{#394640} |