Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1988543002: Better counting of /deep/ usage (Closed)

Created:
4 years, 7 months ago by shans
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, asvitkine+watch_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Better counting of /deep/ usage Better counting of /deep/ usage. The new counter will only trigger when /deep/ does something different to the standard descendant combinator. BUG=489954 Committed: https://crrev.com/1b0aab34b5ef9e168f1627703da1cc07c092ab62 Cr-Commit-Position: refs/heads/master@{#394640}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M third_party/WebKit/Source/core/css/SelectorChecker.cpp View 1 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 32 (17 generated)
shanestephens
4 years, 7 months ago (2016-05-17 03:32:43 UTC) #2
Timothy Loh
lgtm
4 years, 7 months ago (2016-05-17 04:02:51 UTC) #5
shanestephens
4 years, 7 months ago (2016-05-17 04:47:10 UTC) #7
Ilya Sherman
histograms.xml lgtm
4 years, 7 months ago (2016-05-17 18:18:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988543002/1
4 years, 7 months ago (2016-05-17 21:44:21 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/7118) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-17 21:48:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988543002/20001
4 years, 7 months ago (2016-05-18 00:17:43 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/191958)
4 years, 7 months ago (2016-05-18 03:20:36 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988543002/20001
4 years, 7 months ago (2016-05-18 03:24:38 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/192147)
4 years, 7 months ago (2016-05-18 04:58:12 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988543002/20001
4 years, 7 months ago (2016-05-18 06:03:08 UTC) #23
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/core/frame/UseCounter.h: While running git apply --index -3 -p1; error: patch ...
4 years, 7 months ago (2016-05-18 06:35:18 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988543002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988543002/40001
4 years, 7 months ago (2016-05-18 21:19:23 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-19 02:24:51 UTC) #30
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 02:25:51 UTC) #32
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1b0aab34b5ef9e168f1627703da1cc07c092ab62
Cr-Commit-Position: refs/heads/master@{#394640}

Powered by Google App Engine
This is Rietveld 408576698