Move generated files to gen/.

Move generated files to gen/.

- The generated SDK goes into gen/patched_sdk.
- Expanded multitests go into gen/codegen_tests.
- Compiled tests go into gen/codegen_output.

R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/edca53ea06c2603acec8f12089f5fba5610bd620

[Bob Nystrom, 2016-05-17 00:54:32]

rnystrom@google.com changed reviewers:
+ jacobr@google.com, jmesserly@google.com

[Jennifer Messerly, 2016-05-17 17:43:52]

Nice this is looking great!

https://codereview.chromium.org/1988503002/diff/1/karma.conf.js
File karma.conf.js (right):

https://codereview.chromium.org/1988503002/diff/1/karma.conf.js#newcode19
karma.conf.js:19: 'gen/codegen_output/async_helper/async_helper.js',
this could be something shorter? like maybe just "test"?

https://codereview.chromium.org/1988503002/diff/1/test/codegen/expect/8invali...
File test/codegen/expect/8invalid-chars.in+file_name.js (left):

https://codereview.chromium.org/1988503002/diff/1/test/codegen/expect/8invali...
test/codegen/expect/8invalid-chars.in+file_name.js:1:
dart_library.library('8invalid-chars.in+file_name', null, /* Imports */[
you can delete the input files for these tests too. There's no point in
compiling them if we don't intend to verify the output.

Only ones that are worth keeping is the ones that are testing non-standard
command line options (like --closure or node-modules), until we can get some
other coverage for them.

https://codereview.chromium.org/1988503002/diff/1/test/codegen_test.dart
File test/codegen_test.dart (right):

https://codereview.chromium.org/1988503002/diff/1/test/codegen_test.dart#newc...
test/codegen_test.dart:126: moduleName, path.dirname(testFile), files.toList(),
_moduleForLibrary);
some long lines

https://codereview.chromium.org/1988503002/diff/1/test/testing.dart
File test/testing.dart (right):

https://codereview.chromium.org/1988503002/diff/1/test/testing.dart#newcode17
test/testing.dart:17: final String ddcDirectory = path.dirname(testDirectory);
"respositoryDirectory" perhaps?

or "devCompilerDirectory" ?

In code, I avoid the term "DDC" like the plague :). TLAs are hard to understand.
It makes sense to us because we talk about it all the time, but it doesn't
convey meaning to anyone outside the project, so I like to spell it out.

[Bob Nystrom, 2016-05-18 00:12:58]

Thanks for the review!

https://codereview.chromium.org/1988503002/diff/1/karma.conf.js
File karma.conf.js (right):

https://codereview.chromium.org/1988503002/diff/1/karma.conf.js#newcode19
karma.conf.js:19: 'gen/codegen_output/async_helper/async_helper.js',
On 2016/05/17 17:43:52, John Messerly wrote:
> this could be something shorter? like maybe just "test"?

I did that at first, but I wanted to do something a little more explicit. There
are actually two test-related directories that get generated. codegen_tests
contains the expanded multi-tests (along with all of the other .files inside
codegen/ and is used as the compiler source. Then the tests in there get
compiled to JS into codegen_output.

I'm not super crazy about those names, though.

https://codereview.chromium.org/1988503002/diff/1/test/codegen/expect/8invali...
File test/codegen/expect/8invalid-chars.in+file_name.js (left):

https://codereview.chromium.org/1988503002/diff/1/test/codegen/expect/8invali...
test/codegen/expect/8invalid-chars.in+file_name.js:1:
dart_library.library('8invalid-chars.in+file_name', null, /* Imports */[
On 2016/05/17 17:43:52, John Messerly wrote:
> you can delete the input files for these tests too. There's no point in
> compiling them if we don't intend to verify the output.
> 
> Only ones that are worth keeping is the ones that are testing non-standard
> command line options (like --closure or node-modules), until we can get some
> other coverage for them.

OK, deleted a bunch more from the top level directory. Let me know if I was
overzealous or missed some. I kept the ones that specified options or looked
"important" to me.

https://codereview.chromium.org/1988503002/diff/1/test/codegen_test.dart
File test/codegen_test.dart (right):

https://codereview.chromium.org/1988503002/diff/1/test/codegen_test.dart#newc...
test/codegen_test.dart:126: moduleName, path.dirname(testFile), files.toList(),
_moduleForLibrary);
On 2016/05/17 17:43:52, John Messerly wrote:
> some long lines

Oops! Done.

https://codereview.chromium.org/1988503002/diff/1/test/testing.dart
File test/testing.dart (right):

https://codereview.chromium.org/1988503002/diff/1/test/testing.dart#newcode17
test/testing.dart:17: final String ddcDirectory = path.dirname(testDirectory);
On 2016/05/17 17:43:52, John Messerly wrote:
> "respositoryDirectory" perhaps?
> 
> or "devCompilerDirectory" ?
> 
> In code, I avoid the term "DDC" like the plague :). TLAs are hard to
understand.
> It makes sense to us because we talk about it all the time, but it doesn't
> convey meaning to anyone outside the project, so I like to spell it out.

Good point. Changed to "repoDirectory". I think "repo" is a common abbreviation
(it's what we use when talking out loud).

[Jennifer Messerly, 2016-05-18 00:22:04]

lgtm

[Bob Nystrom, 2016-05-18 20:48:12]

Description was changed from

==========
Move generated files to gen/.

- The generated SDK goes into gen/patched_sdk.
- Expanded multitests go into gen/codegen_tests.
- Compiled tests go into gen/codegen_output.
==========

to

==========
Move generated files to gen/.

- The generated SDK goes into gen/patched_sdk.
- Expanded multitests go into gen/codegen_tests.
- Compiled tests go into gen/codegen_output.

R=jmesserly@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/edca53ea06c2603acec8f12089f5...
==========

[Bob Nystrom, 2016-05-18 20:48:14]

Committed patchset #2 (id:20001) manually as
edca53ea06c2603acec8f12089f5fba5610bd620 (presubmit successful).