tool/build_sdk.sh - Issue 1988503002: Move generated files to gen/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tool/build_sdk.sh

Issue 1988503002: Move generated files to gen/. (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master

Patch Set: Revise. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « tool/README.md ('k') | tool/patch_sdk.dart » ('j') | no next file with comments »

OLD	NEW
1 #!/bin/bash	1 #!/bin/bash

2 set -e	2 set -e

3 # switch to the root directory of dev_compiler	3 # switch to the root directory of dev_compiler

4 cd $( dirname "${BASH_SOURCE[0]}" )/..	4 cd $( dirname "${BASH_SOURCE[0]}" )/..

5	5

6 echo "*** Patching SDK"	6 echo "*** Patching SDK"

7 dart -c tool/patch_sdk.dart tool/input_sdk tool/generated_sdk	7 dart -c tool/patch_sdk.dart tool/input_sdk gen/patched_sdk

8	8

9 echo "*** Compiling SDK to JavaScript"	9 echo "*** Compiling SDK to JavaScript"

10	10

11 # TODO(jmesserly): break out dart:html & friends.	11 # TODO(jmesserly): break out dart:html & friends.

12 #	12 #

13 # Right now we can't summarize our SDK, so we can't treat it as a normal	13 # Right now we can't summarize our SDK, so we can't treat it as a normal

14 # explicit input (instead we're implicitly compiling against the user's SDK).	14 # explicit input (instead we're implicitly compiling against the user's SDK).

15 #	15 #

16 # Another possible approach is to hard code the dart:* library->module mapping	16 # Another possible approach is to hard code the dart:* library->module mapping

17 # into the compiler itself, so it can emit the correct import.	17 # into the compiler itself, so it can emit the correct import.

18 #	18 #

19 dart -c tool/build_sdk.dart \	19 dart -c tool/build_sdk.dart \

20 --dart-sdk tool/generated_sdk \	20 --dart-sdk gen/patched_sdk \

21 -o lib/runtime/dart_sdk.js \	21 -o lib/runtime/dart_sdk.js \

22 "$@" > tool/sdk_expected_errors.txt	22 "$@" > tool/sdk_expected_errors.txt

OLD	NEW