Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1988473003:
Only simulate click for non-repeat Enter keydown on <a> (Closed)
|
Created:
4 years, 7 months ago by chongz Modified:
4 years, 7 months ago CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionOnly simulate click for non-repeat Enter keydown on <a>
Before CL Blink will simulate click on <a> for every Enter keydown
event, after CL it will only do it for non-repeat keydown.
Firefox and Edge has the similar issue (won't navigate when holding Enter and click), Safari doesn't have the issue.
TEST=1. Find an <a>, hold Enter, left click <a>. The link should navigate.
2. Focus <a> using Tab key, press Enter, Ctrl+Enter, Shift+Enter.
The link should navigate.
BUG=607361
Committed: https://crrev.com/00b2cde9efd718d1a35f9876a2333c41021abf9d
Cr-Commit-Position: refs/heads/master@{#394540}
Patch Set 1 #
Messages
Total messages: 15 (8 generated)
Description was changed from
==========
Only simulate click for non-repeat Enter keydown on <a>
Before CL Blink will simulate click on <a> for every Enter keydown
event, after CL it will only do it for non-repeat keydown.
TEST=1. Find an <a>, hold Enter, left click <a>. The link should navigate.
2. Focus <a> using Tab key, press Enter. The link should navigate.
BUG=607361
==========
to
==========
Only simulate click for non-repeat Enter keydown on <a>
Before CL Blink will simulate click on <a> for every Enter keydown
event, after CL it will only do it for non-repeat keydown.
TEST=1. Find an <a>, hold Enter, left click <a>. The link should navigate.
2. Focus <a> using Tab key, press Enter, Ctrl+Enter, Shift+Enter. The link
should navigate.
BUG=607361
==========
Description was changed from
==========
Only simulate click for non-repeat Enter keydown on <a>
Before CL Blink will simulate click on <a> for every Enter keydown
event, after CL it will only do it for non-repeat keydown.
TEST=1. Find an <a>, hold Enter, left click <a>. The link should navigate.
2. Focus <a> using Tab key, press Enter, Ctrl+Enter, Shift+Enter. The link
should navigate.
BUG=607361
==========
to
==========
Only simulate click for non-repeat Enter keydown on <a>
Before CL Blink will simulate click on <a> for every Enter keydown
event, after CL it will only do it for non-repeat keydown.
TEST=1. Find an <a>, hold Enter, left click <a>. The link should navigate.
2. Focus <a> using Tab key, press Enter, Ctrl+Enter, Shift+Enter.
The link should navigate.
BUG=607361
==========
Description was changed from
==========
Only simulate click for non-repeat Enter keydown on <a>
Before CL Blink will simulate click on <a> for every Enter keydown
event, after CL it will only do it for non-repeat keydown.
TEST=1. Find an <a>, hold Enter, left click <a>. The link should navigate.
2. Focus <a> using Tab key, press Enter, Ctrl+Enter, Shift+Enter.
The link should navigate.
BUG=607361
==========
to
==========
Only simulate click for non-repeat Enter keydown on <a>
Before CL Blink will simulate click on <a> for every Enter keydown
event, after CL it will only do it for non-repeat keydown.
Firefox and Edge has the similar issue (won't navigate when holding Enter and
click), Safari doesn't have the issue.
TEST=1. Find an <a>, hold Enter, left click <a>. The link should navigate.
2. Focus <a> using Tab key, press Enter, Ctrl+Enter, Shift+Enter.
The link should navigate.
BUG=607361
==========
chongz@chromium.org changed reviewers: + pdr@chromium.org
pdr@ can you take a look at this CL please? Thanks! (Since you reviewed this code before)
On 2016/05/17 15:35:36, chongz wrote: > pdr@ can you take a look at this CL please? Thanks! > (Since you reviewed this code before) lgtm; pdr@ seems OOO; you may wish to add a different reviewer so you can get this into M52 branch
chongz@chromium.org changed reviewers: + rbyers@chromium.org
rbyers@ can you take a look at this CL please? Thanks! (The original owner pdr@ is OOO)
LGTM
The CQ bit was checked by chongz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988473003/1
Message was sent while issue was closed.
Description was changed from
==========
Only simulate click for non-repeat Enter keydown on <a>
Before CL Blink will simulate click on <a> for every Enter keydown
event, after CL it will only do it for non-repeat keydown.
Firefox and Edge has the similar issue (won't navigate when holding Enter and
click), Safari doesn't have the issue.
TEST=1. Find an <a>, hold Enter, left click <a>. The link should navigate.
2. Focus <a> using Tab key, press Enter, Ctrl+Enter, Shift+Enter.
The link should navigate.
BUG=607361
==========
to
==========
Only simulate click for non-repeat Enter keydown on <a>
Before CL Blink will simulate click on <a> for every Enter keydown
event, after CL it will only do it for non-repeat keydown.
Firefox and Edge has the similar issue (won't navigate when holding Enter and
click), Safari doesn't have the issue.
TEST=1. Find an <a>, hold Enter, left click <a>. The link should navigate.
2. Focus <a> using Tab key, press Enter, Ctrl+Enter, Shift+Enter.
The link should navigate.
BUG=607361
==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from
==========
Only simulate click for non-repeat Enter keydown on <a>
Before CL Blink will simulate click on <a> for every Enter keydown
event, after CL it will only do it for non-repeat keydown.
Firefox and Edge has the similar issue (won't navigate when holding Enter and
click), Safari doesn't have the issue.
TEST=1. Find an <a>, hold Enter, left click <a>. The link should navigate.
2. Focus <a> using Tab key, press Enter, Ctrl+Enter, Shift+Enter.
The link should navigate.
BUG=607361
==========
to
==========
Only simulate click for non-repeat Enter keydown on <a>
Before CL Blink will simulate click on <a> for every Enter keydown
event, after CL it will only do it for non-repeat keydown.
Firefox and Edge has the similar issue (won't navigate when holding Enter and
click), Safari doesn't have the issue.
TEST=1. Find an <a>, hold Enter, left click <a>. The link should navigate.
2. Focus <a> using Tab key, press Enter, Ctrl+Enter, Shift+Enter.
The link should navigate.
BUG=607361
Committed: https://crrev.com/00b2cde9efd718d1a35f9876a2333c41021abf9d
Cr-Commit-Position: refs/heads/master@{#394540}
==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/00b2cde9efd718d1a35f9876a2333c41021abf9d Cr-Commit-Position: refs/heads/master@{#394540} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
