Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp

Issue 1988473003: Only simulate click for non-repeat Enter keydown on <a> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Simon Hausmann <hausmann@kde.org> 4 * (C) 2000 Simon Hausmann <hausmann@kde.org>
5 * Copyright (C) 2003, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed. 5 * Copyright (C) 2003, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed.
6 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 6 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 350 matching lines...) Expand 10 before | Expand all | Expand 10 after
361 frameRequest.setShouldSetOpener(NeverSetOpener); 361 frameRequest.setShouldSetOpener(NeverSetOpener);
362 } 362 }
363 if (hasRel(RelationNoOpener)) 363 if (hasRel(RelationNoOpener))
364 frameRequest.setShouldSetOpener(NeverSetOpener); 364 frameRequest.setShouldSetOpener(NeverSetOpener);
365 frame->loader().load(frameRequest); 365 frame->loader().load(frameRequest);
366 } 366 }
367 } 367 }
368 368
369 bool isEnterKeyKeydownEvent(Event* event) 369 bool isEnterKeyKeydownEvent(Event* event)
370 { 370 {
371 return event->type() == EventTypeNames::keydown && event->isKeyboardEvent() && toKeyboardEvent(event)->keyIdentifier() == "Enter"; 371 return event->type() == EventTypeNames::keydown && event->isKeyboardEvent() && toKeyboardEvent(event)->keyIdentifier() == "Enter" && !toKeyboardEvent(event) ->repeat();
372 } 372 }
373 373
374 bool isLinkClick(Event* event) 374 bool isLinkClick(Event* event)
375 { 375 {
376 return event->type() == EventTypeNames::click && (!event->isMouseEvent() || toMouseEvent(event)->button() != RightButton); 376 return event->type() == EventTypeNames::click && (!event->isMouseEvent() || toMouseEvent(event)->button() != RightButton);
377 } 377 }
378 378
379 bool HTMLAnchorElement::willRespondToMouseClickEvents() 379 bool HTMLAnchorElement::willRespondToMouseClickEvents()
380 { 380 {
381 return isLink() || HTMLElement::willRespondToMouseClickEvents(); 381 return isLink() || HTMLElement::willRespondToMouseClickEvents();
382 } 382 }
383 383
384 bool HTMLAnchorElement::isInteractiveContent() const 384 bool HTMLAnchorElement::isInteractiveContent() const
385 { 385 {
386 return isLink(); 386 return isLink();
387 } 387 }
388 388
389 Node::InsertionNotificationRequest HTMLAnchorElement::insertedInto(ContainerNode * insertionPoint) 389 Node::InsertionNotificationRequest HTMLAnchorElement::insertedInto(ContainerNode * insertionPoint)
390 { 390 {
391 InsertionNotificationRequest request = HTMLElement::insertedInto(insertionPo int); 391 InsertionNotificationRequest request = HTMLElement::insertedInto(insertionPo int);
392 logAddElementIfIsolatedWorldAndInDocument("a", hrefAttr); 392 logAddElementIfIsolatedWorldAndInDocument("a", hrefAttr);
393 return request; 393 return request;
394 } 394 }
395 395
396 } // namespace blink 396 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698