chrome/browser/ui/webui/settings/settings_manage_profile_handler.h - Issue 1988463002: MD Settings: Convert C++ handlers to be JavaScript-lifecycle aware.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/settings_manage_profile_handler.h

Issue 1988463002: MD Settings: Convert C++ handlers to be JavaScript-lifecycle aware. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/settings/settings_default_browser_handler.cc ('k') | chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc » ('j') | chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/settings_manage_profile_handler.h

diff --git a/chrome/browser/ui/webui/settings/settings_manage_profile_handler.h b/chrome/browser/ui/webui/settings/settings_manage_profile_handler.h

index ba4e3d50adb89f71da52993bc5a08159ce7db186..0058fdaa069e8f2c7b1f1e2cebcc8f0995508fef 100644

--- a/chrome/browser/ui/webui/settings/settings_manage_profile_handler.h

+++ b/chrome/browser/ui/webui/settings/settings_manage_profile_handler.h

@@ -30,11 +30,14 @@ class ManageProfileHandler : public settings::SettingsPageUIHandler,

// settings::SettingsPageUIHandler:

void RegisterMessages() override;

+ void OnJavascriptAllowed() override;

+ void OnJavascriptDisallowed() override;

// ProfileAttributesStorage::Observer:

void OnProfileAvatarChanged(const base::FilePath& profile_path) override;

private:

+ friend class ManageProfileHandlerTest;

Dan Beam 2016/05/19 03:36:54 you don't need this if you just raise access to pu

tommycli 2016/05/19 19:27:15 Done.

FRIEND_TEST_ALL_PREFIXES(ManageProfileHandlerTest,

HandleSetProfileIconAndName);

FRIEND_TEST_ALL_PREFIXES(ManageProfileHandlerTest, HandleGetAvailableIcons);