Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1988413003: Enable main frame before activation on waterfall. (Closed)

Created:
4 years, 7 months ago by sunnyps
Modified:
4 years, 7 months ago
Reviewers:
rkaplow
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable main frame before activation on waterfall. This CL enables the main frame before activation on the waterfall so that we have adequate coverage while we launch this via Finch. R=rkaplow@chromium.org BUG=612596 Committed: https://crrev.com/36a74489ec5e4fb898a7984398ad79b3798f70d7 Cr-Commit-Position: refs/heads/master@{#395206}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M testing/variations/fieldtrial_testing_config_android.json View 1 chunk +8 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_chromeos.json View 1 chunk +8 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_linux.json View 1 chunk +8 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_mac.json View 1 chunk +8 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_win.json View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988413003/1
4 years, 7 months ago (2016-05-19 01:07:08 UTC) #2
sunnyps
PTAL Does changing the field trial config affect the CQ immediately? i.e. Are the results ...
4 years, 7 months ago (2016-05-19 02:13:53 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/164169) win_chromium_x64_rel_ng on ...
4 years, 7 months ago (2016-05-19 02:21:50 UTC) #5
sunnyps
On 2016/05/19 02:13:53, sunnyps wrote: > PTAL > > Does changing the field trial config ...
4 years, 7 months ago (2016-05-19 02:33:35 UTC) #6
rkaplow
lgtm yep
4 years, 7 months ago (2016-05-19 17:09:08 UTC) #7
sunnyps
Thanks! Waiting for https://codereview.chromium.org/1997473003 to land before I flip the switch on this.
4 years, 7 months ago (2016-05-19 20:37:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988413003/1
4 years, 7 months ago (2016-05-20 22:34:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 23:40:19 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 23:42:59 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36a74489ec5e4fb898a7984398ad79b3798f70d7
Cr-Commit-Position: refs/heads/master@{#395206}

Powered by Google App Engine
This is Rietveld 408576698