Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1997473003: cc: Remove unnecessary DCHECK and dead code from scheduler. (Closed)

Created:
4 years, 7 months ago by sunnyps
Modified:
4 years, 7 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove unnecessary DCHECK and dead code from scheduler. This removes a DCHECK which fails in main frame before activation mode and cleans some of the code in WillCommit. Some dead code around forced redraw state is also removed. R=enne@chromium.org BUG=612596 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/0e8a1ccc39289aaaec0ecfb73c2eee995de3715e Cr-Commit-Position: refs/heads/master@{#394874}

Patch Set 1 #

Patch Set 2 : waterfall config for testing #

Patch Set 3 : revert waterfall config #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -24 lines) Patch
M cc/scheduler/scheduler_state_machine.cc View 3 chunks +9 lines, -24 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
sunnyps
PTAL I will revert the changes to the waterfall config after a dry run passes ...
4 years, 7 months ago (2016-05-19 02:55:08 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997473003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997473003/20001
4 years, 7 months ago (2016-05-19 02:55:40 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-19 04:02:52 UTC) #6
enne (OOO)
lgtm
4 years, 7 months ago (2016-05-19 18:33:39 UTC) #7
enne (OOO)
Nice cleanup!
4 years, 7 months ago (2016-05-19 18:33:45 UTC) #8
sunnyps
Thanks!
4 years, 7 months ago (2016-05-19 20:35:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1997473003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1997473003/40001
4 years, 7 months ago (2016-05-19 20:36:39 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-19 21:33:45 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 21:35:09 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0e8a1ccc39289aaaec0ecfb73c2eee995de3715e
Cr-Commit-Position: refs/heads/master@{#394874}

Powered by Google App Engine
This is Rietveld 408576698