Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1988363002: [Mac/GN] Set breakpad_uploads in tweak_info_plist for official Chrome builds. (Closed)

Created:
4 years, 7 months ago by Robert Sesek
Modified:
4 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Set breakpad_uploads in tweak_info_plist for official Chrome builds. BUG=431177 R=mark@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/ce0bc2f8a57d842653797449043b58bc24c98da4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M build/config/features.gni View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/BUILD.gn View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Robert Sesek
4 years, 7 months ago (2016-05-18 20:25:31 UTC) #1
Mark Mentovai
LGTM
4 years, 7 months ago (2016-05-18 20:49:23 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ce0bc2f8a57d842653797449043b58bc24c98da4 Cr-Commit-Position: refs/heads/master@{#394555}
4 years, 7 months ago (2016-05-18 21:32:23 UTC) #4
Robert Sesek
4 years, 7 months ago (2016-05-18 21:33:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ce0bc2f8a57d842653797449043b58bc24c98da4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698