chrome/BUILD.gn - Issue 1988363002: [Mac/GN] Set breakpad_uploads in tweak_info_plist for official Chrome builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/BUILD.gn

Issue 1988363002: [Mac/GN] Set breakpad_uploads in tweak_info_plist for official Chrome builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/BUILD.gn

diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn

index 587ddce56849e8eaabe4523d5da0d193b9bf1474..7052c70cef4ce3ff5a6850ecbca5b55526e02ed9 100644

--- a/chrome/BUILD.gn

+++ b/chrome/BUILD.gn

@@ -719,11 +719,13 @@ if (is_win) {

tweak_info_plist("chrome_framework_plist") {

info_plist = "app/framework-Info.plist"

+ _breakpad_uploads_arg = "0"

+ if (enable_mac_crash_collection) {

+ _breakpad_uploads_arg = "1"

+ }

args = [

"--breakpad=1",

- #"--breakpad_uploads=???", # TODO(rsesek): Breakpad uploads.

+ "--breakpad_uploads=$_breakpad_uploads_arg",

"--keystone=0",

"--scm=1",

"--branding",

« no previous file with comments | « build/config/features.gni ('k') | no next file » | no next file with comments »