net/cookies/cookie_store_unittest.h - Issue 1988343003: Access-time threshold unit failure in CookieMonster.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cookies/cookie_store_unittest.h

Issue 1988343003: Access-time threshold unit failure in CookieMonster. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Alternate proposal. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cookies/cookie_store_unittest.h

diff --git a/net/cookies/cookie_store_unittest.h b/net/cookies/cookie_store_unittest.h

index d75d8f7d81ed0a32f830b084f73e743c830b51b3..7c677cbeaecad8985c8f39d01391908ee6b5c689 100644

--- a/net/cookies/cookie_store_unittest.h

+++ b/net/cookies/cookie_store_unittest.h

@@ -1125,7 +1125,8 @@ TYPED_TEST_P(CookieStoreTest, TestSecure) {

this->GetCookies(cs, this->https_www_google_.url()));

}

-static const int kLastAccessThresholdMilliseconds = 200;

+static const base::TimeDelta kLastAccessThreshold =

+ base::TimeDelta::FromMilliseconds(200);

Scott Hess - ex-Googler 2016/05/18 22:35:20 AFAICT this is only referenced by cookie_monster_u

Ryan Sleevi 2016/05/18 23:07:07 Agreed (if you want to move it there)

Scott Hess - ex-Googler 2016/05/18 23:14:29 Done.

// Formerly NetUtilTest.CookieTest back when we used wininet's cookie handling.

TYPED_TEST_P(CookieStoreTest, NetUtilCookieTest) {

« net/cookies/cookie_monster.h ('K') | « net/cookies/cookie_monster_unittest.cc ('k') | no next file » | no next file with comments »