Access-time threshold unit failure in CookieMonster.

net/cookies/cookie_store_unittest.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_COOKIES_COOKIE_STORE_UNITTEST_H_
 #define NET_COOKIES_COOKIE_STORE_UNITTEST_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 1107 matching lines @@
                          this->GetCookies(cs, this->https_www_google_.url()));
 
   EXPECT_TRUE(this->SetCookie(cs, this->https_www_google_.url(), "A=B"));
   // The non-secure should overwrite the secure.
   this->MatchCookieLines("A=B",
                          this->GetCookies(cs, this->http_www_google_.url()));
   this->MatchCookieLines("D=E; A=B",
                          this->GetCookies(cs, this->https_www_google_.url()));
 }
 
-static const int kLastAccessThresholdMilliseconds = 200;
+static const base::TimeDelta kLastAccessThreshold =
+    base::TimeDelta::FromMilliseconds(200);

[Scott Hess - ex-Googler, 2016/05/18 22:35:20]

AFAICT this is only referenced by cookie_monster_unittest.cc, so maybe this
isn't the place for it?

[Ryan Sleevi, 2016/05/18 23:07:07]

Agreed (if you want to move it there)

[Scott Hess - ex-Googler, 2016/05/18 23:14:29]

Done.

 
 // Formerly NetUtilTest.CookieTest back when we used wininet's cookie handling.
 TYPED_TEST_P(CookieStoreTest, NetUtilCookieTest) {
   const GURL test_url("http://mojo.jojo.google.izzle/");
 
   CookieStore* cs = this->GetCookieStore();
 
   EXPECT_TRUE(this->SetCookie(cs, test_url, "foo=bar"));
   std::string value = this->GetCookies(cs, test_url);
   this->MatchCookieLines("foo=bar", value);
@@ skipping 269 matching lines @@
                            OverwritePersistentCookie,
                            CookieOrdering,
                            GetAllCookiesAsync,
                            DeleteCookieAsync,
                            DeleteCanonicalCookieAsync,
                            DeleteSessionCookie);
 
 }  // namespace net
 
 #endif  // NET_COOKIES_COOKIE_STORE_UNITTEST_H_