Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 198833004: Clean up repeated code in picture pile unittest (Closed)

Created:
6 years, 9 months ago by enne (OOO)
Modified:
6 years, 9 months ago
Reviewers:
danakj, vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Clean up repeated code in picture pile unittest This is just a prefactoring to make it easier to write another picture pile test for the given bug. BUG=353346 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257766

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -164 lines) Patch
M cc/resources/picture_pile_unittest.cc View 4 chunks +94 lines, -164 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
enne (OOO)
6 years, 9 months ago (2014-03-18 00:21:03 UTC) #1
danakj
LGTM
6 years, 9 months ago (2014-03-18 17:14:04 UTC) #2
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-03-18 17:16:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/198833004/1
6 years, 9 months ago (2014-03-18 17:35:03 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 21:26:50 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-18 21:26:52 UTC) #6
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 9 months ago (2014-03-18 21:27:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/198833004/1
6 years, 9 months ago (2014-03-18 21:29:04 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-18 21:37:46 UTC) #9
Message was sent while issue was closed.
Change committed as 257766

Powered by Google App Engine
This is Rietveld 408576698