Fix depth texture sampling on compatibility profile.

Fix depth texture sampling on compatibility profile.

With this fix, all depth texture related tests under
deqp/texturespecification/ begin to pass on Linux with compatibility
profile.

BUG=429053
TEST=webgl2 on linux gpu bots
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/6848761925717b71d928a09809c1ac11cac701ee
Cr-Commit-Position: refs/heads/master@{#394619}

[Zhenyao Mo, 2016-05-18 19:59:59]

Description was changed from

==========
Fix depth texture sampling on compatibility profile.

With this fix, all depth texture related tests under
deqp/texturespecification/ begin to pass on Linux with compatibility
profile.

BUG=429053
TEST=webgl2 on linux gpu bots
R=piman@chromium.org
==========

to

==========
Fix depth texture sampling on compatibility profile.

With this fix, all depth texture related tests under
deqp/texturespecification/ begin to pass on Linux with compatibility
profile.

BUG=429053
TEST=webgl2 on linux gpu bots
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-05-18 20:00:36]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[Zhenyao Mo, 2016-05-18 20:00:52]

piman: PTAL

[commit-bot: I haz the power, 2016-05-18 20:01:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988303002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988303002/1

[Ken Russell (switch to Gerrit), 2016-05-18 20:23:49]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-05-18 20:23:50]

Great catch Mo!

[Ken Russell (switch to Gerrit), 2016-05-18 20:24:15]

LGTM from my standpoint but I'm not an owner.

[commit-bot: I haz the power, 2016-05-18 20:28:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-18 20:28:13]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[piman, 2016-05-18 21:00:15]

https://codereview.chromium.org/1988303002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/1988303002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:5249: }
Can you explain to me why this is needed and what issue it solves? This is way
far from obvious.

[Zhenyao Mo, 2016-05-18 21:16:26]

On 2016/05/18 21:00:15, piman wrote:
>
https://codereview.chromium.org/1988303002/diff/1/gpu/command_buffer/service/...
> File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):
> 
>
https://codereview.chromium.org/1988303002/diff/1/gpu/command_buffer/service/...
> gpu/command_buffer/service/gles2_cmd_decoder.cc:5249: }
> Can you explain to me why this is needed and what issue it solves? This is way
> far from obvious.

In compatibility profile, "The resulting r is assigned to Rt
, Lt, It, or At if the value of DEPTH_TEXTURE_MODE is respectively RED,
LUMINANCE, INTENSITY, or ALPHA."

In ES3 and core profile, "The resulting r is assigned to Rt." (ES3.0.4 spec page
164)

[piman, 2016-05-18 21:25:40]

On Wed, May 18, 2016 at 2:16 PM, <zmo@chromium.org> wrote:

> On 2016/05/18 21:00:15, piman wrote:
> >
>
>
https://codereview.chromium.org/1988303002/diff/1/gpu/command_buffer/service/...
> > File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):
> >
> >
>
>
https://codereview.chromium.org/1988303002/diff/1/gpu/command_buffer/service/...
> > gpu/command_buffer/service/gles2_cmd_decoder.cc:5249: }
> > Can you explain to me why this is needed and what issue it solves? This
> is way
> > far from obvious.
>
> In compatibility profile, "The resulting r is assigned to Rt
> , Lt, It, or At if the value of DEPTH_TEXTURE_MODE is respectively RED,
> LUMINANCE, INTENSITY, or ALPHA."
>
> In ES3 and core profile, "The resulting r is assigned to Rt." (ES3.0.4
> spec page
> 164)
>

Ok, can you add it as a comment?
But please note that GL_DEPTH_TEXTURE_MODE is not available before OpenGL
3.1. This would be called unconditionally on GL<3.1 and cause an error.
Maybe you want to only do this if GL>3.1 or if GL_ARB_depth_texture is
present?


>
> https://codereview.chromium.org/1988303002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Zhenyao Mo, 2016-05-18 22:12:20]

On 2016/05/18 21:25:40, piman wrote:
> On Wed, May 18, 2016 at 2:16 PM, <mailto:zmo@chromium.org> wrote:
> 
> > On 2016/05/18 21:00:15, piman wrote:
> > >
> >
> >
>
https://codereview.chromium.org/1988303002/diff/1/gpu/command_buffer/service/...
> > > File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):
> > >
> > >
> >
> >
>
https://codereview.chromium.org/1988303002/diff/1/gpu/command_buffer/service/...
> > > gpu/command_buffer/service/gles2_cmd_decoder.cc:5249: }
> > > Can you explain to me why this is needed and what issue it solves? This
> > is way
> > > far from obvious.
> >
> > In compatibility profile, "The resulting r is assigned to Rt
> > , Lt, It, or At if the value of DEPTH_TEXTURE_MODE is respectively RED,
> > LUMINANCE, INTENSITY, or ALPHA."
> >
> > In ES3 and core profile, "The resulting r is assigned to Rt." (ES3.0.4
> > spec page
> > 164)
> >
> 
> Ok, can you add it as a comment?

Done.

> But please note that GL_DEPTH_TEXTURE_MODE is not available before OpenGL
> 3.1. This would be called unconditionally on GL<3.1 and cause an error.
> Maybe you want to only do this if GL>3.1 or if GL_ARB_depth_texture is
> present?

Done. 3.2 or later.  Surprisingly, ARB_depth_texture doesn't support RED for
DEPTH_TEXTURE_MODE.

> 
> 
> >
> > https://codereview.chromium.org/1988303002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[Zhenyao Mo, 2016-05-18 22:12:26]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[Zhenyao Mo, 2016-05-18 22:12:40]

Please take another look.

[commit-bot: I haz the power, 2016-05-18 22:12:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988303002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988303002/20001

[piman, 2016-05-18 23:04:19]

LGTM, thanks!

[commit-bot: I haz the power, 2016-05-19 00:21:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 00:21:50]

Dry run: This issue passed the CQ dry run.

[Zhenyao Mo, 2016-05-19 00:30:53]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2016-05-19 00:30:53]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/1988303002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-05-19 00:32:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988303002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988303002/20001

[commit-bot: I haz the power, 2016-05-19 00:43:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-19 00:46:31]

Description was changed from

==========
Fix depth texture sampling on compatibility profile.

With this fix, all depth texture related tests under
deqp/texturespecification/ begin to pass on Linux with compatibility
profile.

BUG=429053
TEST=webgl2 on linux gpu bots
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix depth texture sampling on compatibility profile.

With this fix, all depth texture related tests under
deqp/texturespecification/ begin to pass on Linux with compatibility
profile.

BUG=429053
TEST=webgl2 on linux gpu bots
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/6848761925717b71d928a09809c1ac11cac701ee
Cr-Commit-Position: refs/heads/master@{#394619}
==========

[commit-bot: I haz the power, 2016-05-19 00:46:33]

Patchset 2 (id:??) landed as
https://crrev.com/6848761925717b71d928a09809c1ac11cac701ee
Cr-Commit-Position: refs/heads/master@{#394619}