gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc - Issue 1988303002: Fix depth texture sampling on compatibility profile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc

Issue 1988303002: Fix depth texture sampling on compatibility profile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h ('k') | gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc

index 668798c937ab74e258c5d0912b22e37d5c79cc1e..252eb8d688877a02d74940bf4ec7f9a74dc6590a 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc

@@ -31,6 +31,7 @@

using ::gfx::MockGLInterface;

using ::testing::_;

using ::testing::AnyNumber;

+using ::testing::AtMost;

using ::testing::DoAll;

using ::testing::InSequence;

using ::testing::Invoke;

@@ -1156,6 +1157,11 @@ void GLES2DecoderTestBase::DoBindTexture(

EXPECT_CALL(*gl_, BindTexture(target, service_id))

.Times(1)

.RetiresOnSaturation();

+ if (!group_->feature_info()->gl_version_info().BehavesLikeGLES() &&

+ group_->feature_info()->gl_version_info().IsAtLeastGL(3, 2)) {

+ EXPECT_CALL(*gl_, TexParameteri(target, GL_DEPTH_TEXTURE_MODE, GL_RED))

+ .Times(AtMost(1));

+ }

cmds::BindTexture cmd;

cmd.Init(target, client_id);

EXPECT_EQ(error::kNoError, ExecuteCmd(cmd));