Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1988223002: [Mac][Material Design] Bring bookmark hover background up to spec. (Closed)

Created:
4 years, 7 months ago by shrike
Modified:
4 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac][Material Design] Bring bookmark hover background up to spec. The MD hover background currently does not match the spec. R=avi@chromium.org BUG=612598 Committed: https://crrev.com/d6bb602b460c9e39739a1e934347d278bd6b501b Cr-Commit-Position: refs/heads/master@{#394599}

Patch Set 1 #

Patch Set 2 : Fix test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -23 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 2 chunks +2 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm View 4 chunks +11 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm View 1 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/gradient_button_cell.mm View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
shrike
PTAL
4 years, 7 months ago (2016-05-18 20:20:03 UTC) #1
Avi (use Gerrit)
lgtm
4 years, 7 months ago (2016-05-18 20:25:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988223002/1
4 years, 7 months ago (2016-05-18 21:26:25 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/113725)
4 years, 7 months ago (2016-05-18 22:05:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988223002/20001
4 years, 7 months ago (2016-05-18 22:25:33 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-18 23:33:26 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 23:35:04 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d6bb602b460c9e39739a1e934347d278bd6b501b
Cr-Commit-Position: refs/heads/master@{#394599}

Powered by Google App Engine
This is Rietveld 408576698