Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h

Issue 1988223002: [Mac][Material Design] Bring bookmark hover background up to spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Constants used for positioning the bookmark bar. These aren't placed in a 5 // Constants used for positioning the bookmark bar. These aren't placed in a
6 // different file because they're conditionally included in cross platform code 6 // different file because they're conditionally included in cross platform code
7 // and thus no Objective-C++ stuff. 7 // and thus no Objective-C++ stuff.
8 8
9 #ifndef CHROME_BROWSER_UI_COCOA_BOOKMARKS_BOOKMARK_BAR_CONSTANTS_H_ 9 #ifndef CHROME_BROWSER_UI_COCOA_BOOKMARKS_BOOKMARK_BAR_CONSTANTS_H_
10 #define CHROME_BROWSER_UI_COCOA_BOOKMARKS_BOOKMARK_BAR_CONSTANTS_H_ 10 #define CHROME_BROWSER_UI_COCOA_BOOKMARKS_BOOKMARK_BAR_CONSTANTS_H_
11 11
12 #include <ApplicationServices/ApplicationServices.h> 12 #include <ApplicationServices/ApplicationServices.h>
13 13
14 #include "chrome/browser/ui/bookmarks/bookmark_bar_constants.h" 14 #include "chrome/browser/ui/bookmarks/bookmark_bar_constants.h"
15 15
16 namespace bookmarks { 16 namespace bookmarks {
17 17
18 // Correction used for computing other values based on the height. 18 // Correction used for computing other values based on the height.
19 const int kVisualHeightOffset = 2; 19 const int kVisualHeightOffset = 2;
20 const int kMaterialVisualHeightOffset = 0; 20 const int kMaterialVisualHeightOffset = 2;
21 21
22 // The amount of space between the inner bookmark bar and the outer toolbar on 22 // The amount of space between the inner bookmark bar and the outer toolbar on
23 // new tab pages. 23 // new tab pages.
24 const int kNTPBookmarkBarPadding = 24 const int kNTPBookmarkBarPadding =
25 (chrome::kNTPBookmarkBarHeight - 25 (chrome::kNTPBookmarkBarHeight -
26 (chrome::kBookmarkBarHeight + kVisualHeightOffset)) / 2; 26 (chrome::kBookmarkBarHeight + kVisualHeightOffset)) / 2;
27 const int kMaterialNTPBookmarkBarPadding =
28 (chrome::kNTPBookmarkBarHeight -
29 (chrome::kBookmarkBarHeight + kMaterialVisualHeightOffset)) / 2;
30 27
31 // The height of buttons in the bookmark bar. 28 // The height of buttons in the bookmark bar.
32 const int kBookmarkButtonHeight = 29 const int kBookmarkButtonHeight =
33 chrome::kBookmarkBarHeight + kVisualHeightOffset; 30 chrome::kBookmarkBarHeight + kVisualHeightOffset;
34 const int kMaterialBookmarkButtonHeight =
35 chrome::kBookmarkBarHeight + kMaterialVisualHeightOffset;
36 31
37 // The height of buttons in a bookmark bar folder menu. 32 // The height of buttons in a bookmark bar folder menu.
38 const CGFloat kBookmarkFolderButtonHeight = 24.0; 33 const CGFloat kBookmarkFolderButtonHeight = 24.0;
39 34
40 // The radius of the corner curves on the menu. Also used for sizing the shadow 35 // The radius of the corner curves on the menu. Also used for sizing the shadow
41 // window behind the menu window at times when the menu can be scrolled. 36 // window behind the menu window at times when the menu can be scrolled.
42 const CGFloat kBookmarkBarMenuCornerRadius = 4.0; 37 const CGFloat kBookmarkBarMenuCornerRadius = 4.0;
43 38
44 // Overlap (in pixels) between the toolbar and the bookmark bar (when showing in 39 // Overlap (in pixels) between the toolbar and the bookmark bar (when showing in
45 // normal mode). 40 // normal mode).
46 const CGFloat kBookmarkBarOverlap = 3.0; 41 const CGFloat kBookmarkBarOverlap = 3.0;
47 42
48 } // namespace bookmarks 43 } // namespace bookmarks
49 44
50 #endif // CHROME_BROWSER_UI_COCOA_BOOKMARKS_BOOKMARK_BAR_CONSTANTS_H_ 45 #endif // CHROME_BROWSER_UI_COCOA_BOOKMARKS_BOOKMARK_BAR_CONSTANTS_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698