Chromium Code Reviews
DescriptionRevert of [iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*". (patchset #2 id:20001 of https://codereview.chromium.org/1984353002/ )
Reason for revert:
breaks the cq for everyone (e.g. https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/builds/7843/steps/generate_build_files%20%28without%20patch%29/logs/stdio)
Original issue's description:
> [iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*".
>
> Add missing dependencies, add circular include exception for targets that
> are conceptually a single target but split for practical reason, move some
> files and remove obsolete includes to fix "gn check".
>
> Enable "gn check" for "//ios/*" and "//ios_internal/*".
>
> R=dpranke@chromium.org
> TBR=brettw@chromium.org
> BUG=None
>
> Committed: https://crrev.com/9852b77afa1a1b3875a73a091e94f88865c4e78e
> Cr-Commit-Position: refs/heads/master@{#394428}
TBR=dpranke@google.com,ben@chromium.org,brettw@chromium.org,dpranke@chromium.org,sdefresne@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
Committed: https://crrev.com/c1bc2e9a37c56c3b2dc3cc3dfc9adb3a98ed4a83
Cr-Commit-Position: refs/heads/master@{#394458}
Patch Set 1 #
Messages
Total messages: 7 (1 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||