Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1988203002: Revert of [iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*". (Closed)

Created:
4 years, 7 months ago by Nico
Modified:
4 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*". (patchset #2 id:20001 of https://codereview.chromium.org/1984353002/ ) Reason for revert: breaks the cq for everyone (e.g. https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/builds/7843/steps/generate_build_files%20%28without%20patch%29/logs/stdio) Original issue's description: > [iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*". > > Add missing dependencies, add circular include exception for targets that > are conceptually a single target but split for practical reason, move some > files and remove obsolete includes to fix "gn check". > > Enable "gn check" for "//ios/*" and "//ios_internal/*". > > R=dpranke@chromium.org > TBR=brettw@chromium.org > BUG=None > > Committed: https://crrev.com/9852b77afa1a1b3875a73a091e94f88865c4e78e > Cr-Commit-Position: refs/heads/master@{#394428} TBR=dpranke@google.com,ben@chromium.org,brettw@chromium.org,dpranke@chromium.org,sdefresne@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/c1bc2e9a37c56c3b2dc3cc3dfc9adb3a98ed4a83 Cr-Commit-Position: refs/heads/master@{#394458}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -77 lines) Patch
M .gn View 1 chunk +1 line, -2 lines 0 comments Download
M ios/chrome/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/app/strings/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/BUILD.gn View 13 chunks +19 lines, -38 lines 0 comments Download
M ios/chrome/browser/autofill/form_input_accessory_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ios_chrome_io_thread.mm View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ios_chrome_main_parts.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/search_engines/template_url_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/search_engines/ui_thread_search_terms_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/common/app_group/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M ios/chrome/test/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/net/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/public/provider/chrome/browser/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/public/provider/web/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/web/BUILD.gn View 3 chunks +1 line, -4 lines 0 comments Download
M ios/web/public/app/BUILD.gn View 1 chunk +2 lines, -4 lines 0 comments Download
M ios/web/shell/BUILD.gn View 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Nico
Created Revert of [iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*".
4 years, 7 months ago (2016-05-18 17:24:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988203002/1
4 years, 7 months ago (2016-05-18 17:24:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 17:26:12 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c1bc2e9a37c56c3b2dc3cc3dfc9adb3a98ed4a83 Cr-Commit-Position: refs/heads/master@{#394458}
4 years, 7 months ago (2016-05-18 17:28:23 UTC) #5
sdefresne
lgtm Thanks.
4 years, 7 months ago (2016-05-18 17:40:19 UTC) #6
Dirk Pranke
4 years, 7 months ago (2016-05-18 19:22:05 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698