Revert of [iOS/GN] Fix and enable "gn check" for "//ios/*" and "//ios_internal/*".

ios/chrome/browser/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/features.gni")
 import("//ios/web/js_compile.gni")
 import("//third_party/protobuf/proto_library.gni")
 
 declare_args() {
   google_test_gaia_client_id = ""
@@ skipping 145 matching lines @@
     "find_in_page/js_findinpage_manager.mm",
     "first_run/first_run.h",
     "first_run/first_run.mm",
     "first_run/first_run_configuration.h",
     "first_run/first_run_configuration.mm",
     "first_run/first_run_metrics.h",
     "geolocation/CLLocation+OmniboxGeolocation.h",
     "geolocation/CLLocation+OmniboxGeolocation.mm",
     "geolocation/CLLocation+XGeoHeader.h",
     "geolocation/CLLocation+XGeoHeader.mm",
-    "geolocation/location_manager+Testing.h",
     "geolocation/location_manager.h",
     "geolocation/location_manager.mm",
     "geolocation/omnibox_geolocation_authorization_alert.h",
     "geolocation/omnibox_geolocation_authorization_alert.mm",
     "geolocation/omnibox_geolocation_config.h",
     "geolocation/omnibox_geolocation_config.mm",
     "geolocation/omnibox_geolocation_local_state.h",
     "geolocation/omnibox_geolocation_local_state.mm",
     "google/google_brand.h",
     "google/google_brand.mm",
@@ skipping 358 matching lines @@
     "web_resource/web_resource_util.cc",
     "web_resource/web_resource_util.h",
     "xcallback_parameters.h",
     "xcallback_parameters.mm",
   ]
 
   deps = [
     ":about_flags",
     ":injected_js",
     "//base",
-    "//base:i18n",
     "//breakpad:client",
     "//components/about_handler",
     "//components/autofill/core/browser",
     "//components/autofill/core/common",
     "//components/autofill/ios/browser",
     "//components/bookmarks/browser",
     "//components/browser_sync/browser",
     "//components/browser_sync/common",
     "//components/browsing_data_ui",
     "//components/certificate_reporting",
     "//components/component_updater",
     "//components/content_settings/core/browser",
-    "//components/content_settings/core/common",
     "//components/cookie_config",
     "//components/crash/core/browser",
     "//components/crash/core/common",
-    "//components/data_reduction_proxy/core/common",
     "//components/dom_distiller/core",
     "//components/dom_distiller/ios",
     "//components/favicon/core",
     "//components/favicon_base",
-    "//components/flags_ui",
     "//components/gcm_driver",
     "//components/google/core/browser",
     "//components/history/core/browser",
     "//components/history/ios/browser",
     "//components/image_fetcher",
     "//components/infobars/core",
     "//components/invalidation/impl",
     "//components/invalidation/public",
     "//components/keyed_service/core",
     "//components/keyed_service/ios",
     "//components/language_usage_metrics",
     "//components/leveldb_proto",
     "//components/metrics",
     "//components/metrics:net",
     "//components/metrics:profiler",
     "//components/metrics:profiler_ios",
     "//components/metrics:ui",
     "//components/metrics_services_manager",
     "//components/navigation_metrics",
     "//components/net_log",
     "//components/network_time",
     "//components/ntp_snippets",
     "//components/omnibox/browser",
     "//components/open_from_clipboard",
     "//components/password_manager/core/browser",
-    "//components/password_manager/core/common",
     "//components/password_manager/sync/browser",
     "//components/policy:policy_component_common",
     "//components/pref_registry",
     "//components/prefs",
     "//components/profile_metrics",
     "//components/proxy_config",
     "//components/rappor",
     "//components/resources",
     "//components/search",
     "//components/search_engines",
     "//components/security_interstitials/core",
     "//components/security_state",
     "//components/sessions",
     "//components/signin/core/browser",
     "//components/signin/core/common",
     "//components/signin/ios/browser",
     "//components/ssl_config",
     "//components/strings",
     "//components/suggestions",
     "//components/sync_driver",
     "//components/sync_sessions",
     "//components/syncable_prefs",
     "//components/translate/core/browser",
-    "//components/translate/core/common",
     "//components/translate/ios/browser",
     "//components/undo",
     "//components/update_client",
     "//components/upload_list",
     "//components/url_formatter",
     "//components/user_prefs",
     "//components/variations",
     "//components/variations/service",
     "//components/version_info",
     "//components/version_ui",
     "//components/web_resource",
     "//components/webdata_services",
     "//components/webp_transcode",
     "//google_apis",
     "//ios/chrome/browser/variations:ios_chrome_ui_string_overrider_factory",
     "//ios/chrome/common",
-    "//ios/chrome/common/app_group",
-    "//ios/net",
     "//ios/public/provider/chrome/browser",
-    "//ios/public/provider/web",
     "//ios/web",
-    "//ios/web:user_agent",
-    "//ios/web/public/app",
     "//net",
     "//net:extras",
     "//skia",
     "//sync",
     "//third_party/google_toolbox_for_mac",
     "//ui/base",
     "//ui/gfx",
-    "//ui/resources",
-    "//ui/strings",
     "//url",
 
     # TODO(crbug.com/459705): add support for resource packing and change the
     # dependency to be on the packed resources instead of the unpacked ones.
     "//ios/chrome/app/resources",
     "//ios/chrome/app/strings",
     "//ios/chrome/app/theme",
   ]
 
-  allow_circular_includes_from = [ ":about_flags" ]
-
   libs = [
     "Accelerate.framework",
     "CoreGraphics.framework",
     "CoreLocation.framework",
     "Foundation.framework",
     "QuartzCore.framework",
     "UIKit.framework",
   ]
 
   if (enable_rlz) {
-    sources += [
-      "rlz/rlz_tracker_delegate_impl.cc",
-      "rlz/rlz_tracker_delegate_impl.h",
-    ]
-
     deps += [
+      ":rlz",
       "//components/rlz",
-      "//rlz:rlz_lib",
     ]
   }
 }
 
 # This is a separate target so that the 'defines' does not leak to the
 # other files (which would increase the compilation time when changing
 # the value).
 source_set("about_flags") {
   visibility = [ ":browser" ]
 
   sources = [
     "about_flags.h",
     "about_flags.mm",
   ]
 
   deps = [
     "//base",
     "//components/autofill/core/common",
     "//components/dom_distiller/core",
     "//components/flags_ui",
-    "//components/flags_ui:switches",
     "//components/strings",
-    "//components/sync_driver",
-    "//components/variations",
     "//google_apis",
     "//ios/chrome/app/strings",
     "//ios/web",
-    "//ios/web:user_agent",
   ]
 
   defines = [
     "GOOGLE_STAGING_API_URL=\"$google_staging_api_url\"",
     "GOOGLE_STAGING_LSO_URL=\"$google_staging_lso_url\"",
     "GOOGLE_TEST_API_URL=\"$google_test_api_url\"",
     "GOOGLE_TEST_LSO_URL=\"$google_test_lso_url\"",
     "GOOGLE_TEST_OAUTH_CLIENT_ID=\"$google_test_oauth_client_id\"",
     "GOOGLE_TEST_OAUTH_CLIENT_SECRET=\"$google_test_oauth_client_secret\"",
     "GOOGLE_TEST_OAUTH_URL=\"$google_test_oauth_url\"",
     "GOOGLE_TEST_SYNC_URL=\"$google_test_sync_url\"",
   ]
 }
 
 # TODO(crbug.com/487804): use js_compile_checked instead once the errors have
 # been fixed.
 js_compile_unchecked("injected_js") {
   visibility = [ ":browser" ]
   sources = [
     "find_in_page/resources/find_in_page.js",
   ]
 }
 
+if (enable_rlz_support) {
+  source_set("rlz") {
+    sources = [
+      "rlz/rlz_tracker_delegate_impl.cc",
+      "rlz/rlz_tracker_delegate_impl.h",
+    ]
+
+    deps = [
+      "//components/google/core/browser",
+      "//components/omnibox/browser",
+      "//components/rlz",
+      "//components/search_engines",
+      "//rlz:rlz_lib",
+    ]
+  }
+}
+
 source_set("test_support") {
   testonly = true
   sources = [
     "browser_state/test_chrome_browser_state.h",
     "browser_state/test_chrome_browser_state.mm",
     "browser_state/test_chrome_browser_state_isolated_context.h",
     "browser_state/test_chrome_browser_state_isolated_context.mm",
+    "geolocation/location_manager+Testing.h",
     "geolocation/test_location_manager.h",
     "geolocation/test_location_manager.mm",
     "net/mock_image_fetcher.h",
     "net/mock_image_fetcher.mm",
     "signin/fake_oauth2_token_service_builder.h",
     "signin/fake_oauth2_token_service_builder.mm",
     "signin/fake_signin_manager_builder.cc",
     "signin/fake_signin_manager_builder.h",
     "sync/fake_sync_service_factory.cc",
     "sync/fake_sync_service_factory.h",
     "sync/ios_chrome_profile_sync_test_util.cc",
     "sync/ios_chrome_profile_sync_test_util.h",
     "sync/sync_setup_service_mock.cc",
     "sync/sync_setup_service_mock.h",
   ]
 
   deps = [
     ":browser",
     "//base",
-    "//components/bookmarks/browser",
-    "//components/browser_sync/browser",
     "//components/browser_sync/browser:test_support",
-    "//components/history/core/browser",
-    "//components/history/ios/browser",
     "//components/keyed_service/core",
     "//components/keyed_service/ios",
     "//components/pref_registry:test_support",
     "//components/signin/core/browser",
-    "//components/signin/core/browser",
-    "//components/signin/core/browser:test_support",
     "//components/signin/ios/browser",
-    "//components/signin/ios/browser:test_support",
     "//components/sync_driver",
     "//components/sync_driver:test_support",
-    "//components/syncable_prefs",
-    "//components/syncable_prefs:test_support",
-    "//components/user_prefs",
-    "//components/webdata_services",
     "//ios/chrome/browser",
     "//ios/chrome/common",
     "//ios/chrome/test",
     "//ios/public/provider/chrome/browser",
     "//ios/public/provider/chrome/browser:test_support",
     "//ios/web",
-    "//net:test_support",
     "//sync",
     "//testing/gmock",
     "//testing/gtest",
     "//ui/base",
     "//url",
   ]
 }