Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1988153003: Fix dangling observer (Closed)

Created:
4 years, 7 months ago by sky
Modified:
4 years, 7 months ago
Reviewers:
msw, James Cook
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix dangling observer UserWindowControllerImpl wasn't properly removing observers it adds. This matters now that there is a call from WindowTreeClientImpls destructor. BUG=612837 TEST=covered by tests R=jamescook@chromium.org, msw@chromium.org Committed: https://crrev.com/546c4972a6173202f2b054abd77ecb7324e64672 Cr-Commit-Position: refs/heads/master@{#394466}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M mash/wm/user_window_controller_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M mash/wm/user_window_controller_impl.cc View 3 chunks +13 lines, -5 lines 1 comment Download

Messages

Total messages: 16 (6 generated)
sky
4 years, 7 months ago (2016-05-18 16:40:40 UTC) #1
James Cook
lgtm
4 years, 7 months ago (2016-05-18 16:55:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988153003/1
4 years, 7 months ago (2016-05-18 16:57:17 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/7804)
4 years, 7 months ago (2016-05-18 17:02:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988153003/1
4 years, 7 months ago (2016-05-18 17:14:53 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/7856)
4 years, 7 months ago (2016-05-18 17:20:47 UTC) #10
msw
lgtm, thanks for fixing that! https://codereview.chromium.org/1988153003/diff/1/mash/wm/user_window_controller_impl.cc File mash/wm/user_window_controller_impl.cc (right): https://codereview.chromium.org/1988153003/diff/1/mash/wm/user_window_controller_impl.cc#newcode93 mash/wm/user_window_controller_impl.cc:93: if (!user_container) optional nit: ...
4 years, 7 months ago (2016-05-18 17:36:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988153003/1
4 years, 7 months ago (2016-05-18 17:39:06 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 18:04:33 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 18:05:51 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/546c4972a6173202f2b054abd77ecb7324e64672
Cr-Commit-Position: refs/heads/master@{#394466}

Powered by Google App Engine
This is Rietveld 408576698