Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: mash/wm/user_window_controller_impl.h

Issue 1988153003: Fix dangling observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mash/wm/user_window_controller_impl.cc » ('j') | mash/wm/user_window_controller_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mash/wm/user_window_controller_impl.h
diff --git a/mash/wm/user_window_controller_impl.h b/mash/wm/user_window_controller_impl.h
index 64df0ad09da1f4bb3c00a6be0870d14fccfa9e73..05db10a5f927d408d7bf4bd435ca95089874198f 100644
--- a/mash/wm/user_window_controller_impl.h
+++ b/mash/wm/user_window_controller_impl.h
@@ -37,6 +37,9 @@ class UserWindowControllerImpl : public mojom::UserWindowController,
private:
void AssignIdIfNecessary(mus::Window* window);
+ // Removes observers from the window and connection.
+ void RemoveObservers(mus::Window* user_container);
+
// Returns the window with the specified user id.
mus::Window* GetUserWindowById(uint32_t id);
@@ -45,6 +48,7 @@ class UserWindowControllerImpl : public mojom::UserWindowController,
// mus::WindowObserver:
void OnTreeChanging(const TreeChangeParams& params) override;
+ void OnWindowDestroying(mus::Window* window) override;
// mus::WindowTreeConnectionObserver:
void OnWindowTreeFocusChanged(mus::Window* gained_focus,
« no previous file with comments | « no previous file | mash/wm/user_window_controller_impl.cc » ('j') | mash/wm/user_window_controller_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698