Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1166)

Unified Diff: third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp

Issue 1988053005: media: Replace wtf/Assertions.h macros in favor of base/logging.h macros (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp b/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
index 10318c7860b6baf80e42ad22e30adee42e978948..1b06696c375a015c7aa437719fa4eeb03cf79c3c 100644
--- a/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
@@ -73,7 +73,7 @@ void MediaElementAudioSourceHandler::setFormat(size_t numberOfChannels, float so
if (numberOfChannels != m_sourceNumberOfChannels || sourceSampleRate != m_sourceSampleRate) {
if (!numberOfChannels || numberOfChannels > AbstractAudioContext::maxNumberOfChannels() || !AudioUtilities::isValidAudioBufferSampleRate(sourceSampleRate)) {
// process() will generate silence for these uninitialized values.
- WTF_LOG(Media, "MediaElementAudioSourceNode::setFormat(%u, %f) - unhandled format change", static_cast<unsigned>(numberOfChannels), sourceSampleRate);
+ DVLOG(3) << "setFormat(" << numberOfChannels << ", " << sourceSampleRate << ") - unhandled format change";
Raymond Toy 2016/05/19 14:48:42 How did you decide on 3? Doesn't WTF_LOG always p
Srirama 2016/05/19 14:54:44 We are using 3 in core/html media files, to make i
Raymond Toy 2016/05/19 15:31:37 I see. I think these are fairly rare. Can we jus
Srirama 2016/05/20 07:33:39 Even WTF_LOG will print only in debug mode and if
// Synchronize with process().
Locker<MediaElementAudioSourceHandler> locker(*this);
m_sourceNumberOfChannels = 0;

Powered by Google App Engine
This is Rietveld 408576698