third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.cpp - Issue 1988053005: media: Replace wtf/Assertions.h macros in favor of base/logging.h macros

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.cpp

Issue 1988053005: media: Replace wtf/Assertions.h macros in favor of base/logging.h macros (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp ('K') | « third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.cpp b/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.cpp

index 860dd15b712c2289b834bdc08f51a65cc7068928..891b7147f482707bbd27992a7d28b49fe7564e18 100644

--- a/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.cpp

@@ -60,7 +60,7 @@ void MediaStreamAudioSourceHandler::setFormat(size_t numberOfChannels, float sou

// The sample-rate must be equal to the context's sample-rate.

if (!numberOfChannels || numberOfChannels > AbstractAudioContext::maxNumberOfChannels() || sourceSampleRate != sampleRate()) {

// process() will generate silence for these uninitialized values.

- WTF_LOG(Media, "MediaStreamAudioSourceNode::setFormat(%u, %f) - unhandled format change", static_cast<unsigned>(numberOfChannels), sourceSampleRate);

+ DVLOG(3) << "setFormat(" << numberOfChannels << ", " << sourceSampleRate << ") - unhandled format change";

Raymond Toy 2016/05/19 14:48:42 Same comment as for MediaElementAudioSource

m_sourceNumberOfChannels = 0;

return;

}