Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1987983002: Remove Range.expand() method

Created:
4 years, 7 months ago by ramya.v
Modified:
4 years, 3 months ago
Reviewers:
tkent
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -310 lines) Patch
D third_party/WebKit/LayoutTests/fast/dom/Range/range-expand.html View 1 chunk +0 lines, -228 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Range/range-expand-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/multicol/float-truncation.html View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/multicol/float-truncation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/multicol/vertical-lr/float-truncation.html View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/multicol/vertical-lr/float-truncation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/multicol/vertical-rl/float-truncation.html View 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/multicol/vertical-rl/float-truncation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/text/international/cjk-segmentation.html View 1 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/text/international/cjk-segmentation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Range.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Range.cpp View 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Range.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
ramya.v
Have updated with selection.modify in place of range.expand. One test is failing. Can you please ...
4 years, 7 months ago (2016-05-18 04:42:16 UTC) #2
ramya.v
Friendly ping! PTAL! Thanks
4 years, 7 months ago (2016-05-23 03:50:44 UTC) #3
tkent
4 years, 7 months ago (2016-05-23 03:53:31 UTC) #4
Please investigate by yourself.
I have no time to debug your code.

Powered by Google App Engine
This is Rietveld 408576698