third_party/WebKit/LayoutTests/fast/multicol/vertical-lr/float-truncation.html - Issue 1987983002: Remove Range.expand() method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/multicol/vertical-lr/float-truncation.html

Issue 1987983002: Remove Range.expand() method Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/multicol/float-truncation-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/multicol/vertical-lr/float-truncation-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/multicol/vertical-lr/float-truncation.html

diff --git a/third_party/WebKit/LayoutTests/fast/multicol/vertical-lr/float-truncation.html b/third_party/WebKit/LayoutTests/fast/multicol/vertical-lr/float-truncation.html

index 6e96866ff1f50d8ad18e6f62fe7686008e1a7153..43aedddc00a0dfeaa6f00daa6bcda175e4c97df6 100644

--- a/third_party/WebKit/LayoutTests/fast/multicol/vertical-lr/float-truncation.html

+++ b/third_party/WebKit/LayoutTests/fast/multicol/vertical-lr/float-truncation.html

@@ -69,11 +69,10 @@

function floatOffset(float)

{

- var range = document.createRange();

- range.setStart(float, 0);

- range.setEnd(float, 0);

- range.expand("word");

- var rect = range.getBoundingClientRect();

+ var selection = getSelection();

+ selection.collapse(float, 0);

+ selection.modify("extend", "forward", "word");

+ var rect = selection.getRangeAt(0).getBoundingClientRect();

var parentRect = float.parentNode.getBoundingClientRect();

return { width: rect.left - parentRect.left, height: rect.top - parentRect.top };

}