Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1987973003: Make FrameSelection::create() to take LocalFrame as required parameter (Closed)

Created:
4 years, 7 months ago by yosin_UTC9
Modified:
4 years, 7 months ago
Reviewers:
yoichio
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make FrameSelection::create() to take LocalFrame as required parameter This patch makes |FrameSelection::create()| to take |LocalFrame| as required parameter instead of optional parameter by utilizing |SelectionModifier| to get rid of null check for |m_frame| member variable in |FrameSelection| class for improving code health. Following patch will get rid of null check for |m_frame| in |FrameSelection|. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/86d103eaec6f31e3c11d1ea7698231f4a589b871 Cr-Commit-Position: refs/heads/master@{#394652}

Patch Set 1 : 2016-05-18T18:48:47 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -17 lines) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp View 6 chunks +14 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
yosin_UTC9
PTAL
4 years, 7 months ago (2016-05-18 09:53:08 UTC) #3
yoichio
lgtm cool!
4 years, 7 months ago (2016-05-19 00:58:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987973003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987973003/1
4 years, 7 months ago (2016-05-19 01:05:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 03:24:39 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 03:25:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86d103eaec6f31e3c11d1ea7698231f4a589b871
Cr-Commit-Position: refs/heads/master@{#394652}

Powered by Google App Engine
This is Rietveld 408576698