third_party/WebKit/Source/core/editing/FrameSelection.cpp - Issue 1987973003: Make FrameSelection::create() to take LocalFrame as required parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.cpp

Issue 1987973003: Make FrameSelection::create() to take LocalFrame as required parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 2016-05-18T18:48:47 Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/FrameSelection.h ('k') | third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/FrameSelection.cpp

diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.cpp b/third_party/WebKit/Source/core/editing/FrameSelection.cpp

index aa0b479dc4111fd7ec7b355ef9618fb8f3046c6a..d9d9bbb899178de5cc51f463887711f9e3c39d0c 100644

--- a/third_party/WebKit/Source/core/editing/FrameSelection.cpp

+++ b/third_party/WebKit/Source/core/editing/FrameSelection.cpp

@@ -107,6 +107,9 @@ FrameSelection::FrameSelection(LocalFrame* frame)

, m_shouldShowBlockCursor(false)

, m_caretBase(adoptPtr(new CaretBase))

{

+ // TODO(yosin): We should remove null check for |m_frame| in

+ // "FrameSelection.cpp", since it never be null.

+ DCHECK(frame);

if (shouldAlwaysUseDirectionalSelection(m_frame))

m_selectionEditor->setIsDirectional(true);

}