Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1987923003: mac/gn: Add missing test to media_unittests. (Closed)

Created:
4 years, 7 months ago by Nico
Modified:
4 years, 7 months ago
Reviewers:
xhwang, DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac/gn: Add missing test to media_unittests. https://codereview.chromium.org/1748333003 forgot to add this test to gn. This is the only test missing in media_unittests. BUG=584119, 604060 Committed: https://crrev.com/0889f3a0a4cee816619636ef78df09f22801068e Cr-Commit-Position: refs/heads/master@{#394325}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M media/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Nico
first to stamp wins!
4 years, 7 months ago (2016-05-18 01:08:05 UTC) #2
DaleCurtis
lgtm
4 years, 7 months ago (2016-05-18 03:28:44 UTC) #3
DaleCurtis
🙋🤗
4 years, 7 months ago (2016-05-18 03:29:27 UTC) #4
Nico
On 2016/05/18 03:29:27, DaleCurtis wrote: > 🙋🤗 Grats! And thanks :-)
4 years, 7 months ago (2016-05-18 03:35:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987923003/1
4 years, 7 months ago (2016-05-18 03:35:47 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 03:39:56 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 03:41:24 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0889f3a0a4cee816619636ef78df09f22801068e
Cr-Commit-Position: refs/heads/master@{#394325}

Powered by Google App Engine
This is Rietveld 408576698