Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1748333003: media: Add MemoryDataSource. (Closed)

Created:
4 years, 9 months ago by xhwang
Modified:
4 years, 9 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Add MemoryDataSource. This is mainly for testing purpose. It will be used by PipelineIntegrationTestBase to test data in memory. Currently PipelineIntegrationTestBase only supports test data in file. BUG=584119 TEST=Added unittest. Committed: https://crrev.com/95acbbaea5077dcd05ba8fce0451b71e7cbe8468 Cr-Commit-Position: refs/heads/master@{#378585}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -0 lines) Patch
M media/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A media/filters/memory_data_source.h View 1 chunk +45 lines, -0 lines 0 comments Download
A media/filters/memory_data_source.cc View 1 chunk +57 lines, -0 lines 0 comments Download
A media/filters/memory_data_source_unittest.cc View 1 chunk +108 lines, -0 lines 0 comments Download
M media/media.gyp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
xhwang
PTAL
4 years, 9 months ago (2016-03-01 17:21:21 UTC) #2
DaleCurtis
lgtm, but I don't quite see the use to this. Are you going to store ...
4 years, 9 months ago (2016-03-01 21:23:32 UTC) #4
xhwang
On 2016/03/01 21:23:32, DaleCurtis wrote: > lgtm, but I don't quite see the use to ...
4 years, 9 months ago (2016-03-01 21:33:47 UTC) #5
DaleCurtis
Ahhh, sorry I'd forgotten about the fuzzer stuff. lgtm
4 years, 9 months ago (2016-03-01 22:06:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748333003/1
4 years, 9 months ago (2016-03-01 22:40:51 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 22:50:33 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 22:52:06 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95acbbaea5077dcd05ba8fce0451b71e7cbe8468
Cr-Commit-Position: refs/heads/master@{#378585}

Powered by Google App Engine
This is Rietveld 408576698