QUIC - add new UMA histograms to help understand HPACK head of line blocking.

QUIC - add new UMA histograms to help understand HPACK head of line blocking.

Histograms of the age of dynamic table entry at each time used to
generate an indexed entry:

  Net.QuicHpackEncoderIndexedEntryAge
  Net.QuicHpackDecoderIndexedEntryAge

BUG=

Committed: https://crrev.com/52b1db11b4c7c53307ee970974d22e0003d23024
Cr-Commit-Position: refs/heads/master@{#395673}

[Buck, 2016-05-20 21:14:25]

Description was changed from

==========
QUIC - add new UMA histograms to help understand HPACK head of line blocking.

Histograms of the age of dynamic table entry at each time used to
generate an indexed entry:

  Net.QuicHpackEncoderIndexedEntryAge
  Net.QuicHpackDecoderIndexedEntryAge

BUG=
==========

to

==========
QUIC - add new UMA histograms to help understand HPACK head of line blocking.

Histograms of the age of dynamic table entry at each time used to
generate an indexed entry:

  Net.QuicHpackEncoderIndexedEntryAge
  Net.QuicHpackDecoderIndexedEntryAge

BUG=
==========

[Buck, 2016-05-20 21:14:26]

ckrasic@chromium.org changed reviewers:
+ asvitkine@chromium.org, rch@chromium.org

[Ryan Hamilton, 2016-05-20 21:27:18]

Cool! Two nits, but LGTM otherwise.

https://codereview.chromium.org/1987913002/diff/160001/net/quic/quic_chromium...
File net/quic/quic_chromium_client_session.cc (right):

https://codereview.chromium.org/1987913002/diff/160001/net/quic/quic_chromium...
net/quic/quic_chromium_client_session.cc:388:
std::unique_ptr<HpackEncoderDebugVisitor>(
fwiw, you can use base::WrapUnique(new ...) to save some verbosity.

https://codereview.chromium.org/1987913002/diff/160001/net/quic/quic_chromium...
File net/quic/quic_chromium_client_session.h (right):

https://codereview.chromium.org/1987913002/diff/160001/net/quic/quic_chromium...
net/quic/quic_chromium_client_session.h:288: };
Looks like these can be moved to the .cc file.

[Buck, 2016-05-20 21:41:31]

https://codereview.chromium.org/1987913002/diff/160001/net/quic/quic_chromium...
File net/quic/quic_chromium_client_session.cc (right):

https://codereview.chromium.org/1987913002/diff/160001/net/quic/quic_chromium...
net/quic/quic_chromium_client_session.cc:388:
std::unique_ptr<HpackEncoderDebugVisitor>(
On 2016/05/20 21:27:18, Ryan Hamilton wrote:
> fwiw, you can use base::WrapUnique(new ...) to save some verbosity.

Done.

https://codereview.chromium.org/1987913002/diff/160001/net/quic/quic_chromium...
File net/quic/quic_chromium_client_session.h (right):

https://codereview.chromium.org/1987913002/diff/160001/net/quic/quic_chromium...
net/quic/quic_chromium_client_session.h:288: };
On 2016/05/20 21:27:18, Ryan Hamilton wrote:
> Looks like these can be moved to the .cc file.

Done.

[Alexei Svitkine (slow), 2016-05-24 18:00:31]

lgtm

https://codereview.chromium.org/1987913002/diff/200001/net/quic/quic_chromium...
File net/quic/quic_chromium_client_session.cc (right):

https://codereview.chromium.org/1987913002/diff/200001/net/quic/quic_chromium...
net/quic/quic_chromium_client_session.cc:149:
"Net.QuicHpackEncoderIndexedEntryAge",
Nit: Maybe slightly more readable if you add another . in between:

Net.QuicHpackEncoder.IndexedEntryAge

If you make the change, also change the one below and histograms.xml.

https://codereview.chromium.org/1987913002/diff/200001/tools/metrics/histogra...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1987913002/diff/200001/tools/metrics/histogra...
tools/metrics/histograms/histograms.xml:28362: +<histogram
name="Net.QuicHpackDecoderIndexedEntryAge" units="millisconds">
Nit: units="ms"

Same below.

[Buck, 2016-05-24 18:15:06]

https://codereview.chromium.org/1987913002/diff/200001/net/quic/quic_chromium...
File net/quic/quic_chromium_client_session.cc (right):

https://codereview.chromium.org/1987913002/diff/200001/net/quic/quic_chromium...
net/quic/quic_chromium_client_session.cc:149:
"Net.QuicHpackEncoderIndexedEntryAge",
On 2016/05/24 18:00:30, Alexei Svitkine (OOO til Tues) wrote:
> Nit: Maybe slightly more readable if you add another . in between:
> 
> Net.QuicHpackEncoder.IndexedEntryAge
> 
> If you make the change, also change the one below and histograms.xml.

Done.

https://codereview.chromium.org/1987913002/diff/200001/tools/metrics/histogra...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1987913002/diff/200001/tools/metrics/histogra...
tools/metrics/histograms/histograms.xml:28362: +<histogram
name="Net.QuicHpackDecoderIndexedEntryAge" units="millisconds">
On 2016/05/24 18:00:30, Alexei Svitkine (OOO til Tues) wrote:
> Nit: units="ms"
> 
> Same below.

Done.

[Buck, 2016-05-24 18:15:18]

The CQ bit was checked by ckrasic@chromium.org

[Buck, 2016-05-24 18:15:19]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org,
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/1987913002/#ps220001
(title: "review feedback")

[commit-bot: I haz the power, 2016-05-24 18:16:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1987913002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1987913002/220001

[commit-bot: I haz the power, 2016-05-24 19:29:27]

Description was changed from

==========
QUIC - add new UMA histograms to help understand HPACK head of line blocking.

Histograms of the age of dynamic table entry at each time used to
generate an indexed entry:

  Net.QuicHpackEncoderIndexedEntryAge
  Net.QuicHpackDecoderIndexedEntryAge

BUG=
==========

to

==========
QUIC - add new UMA histograms to help understand HPACK head of line blocking.

Histograms of the age of dynamic table entry at each time used to
generate an indexed entry:

  Net.QuicHpackEncoderIndexedEntryAge
  Net.QuicHpackDecoderIndexedEntryAge

BUG=
==========

[commit-bot: I haz the power, 2016-05-24 19:29:28]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2016-05-24 19:31:01]

Description was changed from

==========
QUIC - add new UMA histograms to help understand HPACK head of line blocking.

Histograms of the age of dynamic table entry at each time used to
generate an indexed entry:

  Net.QuicHpackEncoderIndexedEntryAge
  Net.QuicHpackDecoderIndexedEntryAge

BUG=
==========

to

==========
QUIC - add new UMA histograms to help understand HPACK head of line blocking.

Histograms of the age of dynamic table entry at each time used to
generate an indexed entry:

  Net.QuicHpackEncoderIndexedEntryAge
  Net.QuicHpackDecoderIndexedEntryAge

BUG=

Committed: https://crrev.com/52b1db11b4c7c53307ee970974d22e0003d23024
Cr-Commit-Position: refs/heads/master@{#395673}
==========

[commit-bot: I haz the power, 2016-05-24 19:31:03]

Patchset 12 (id:??) landed as
https://crrev.com/52b1db11b4c7c53307ee970974d22e0003d23024
Cr-Commit-Position: refs/heads/master@{#395673}