QUIC - add new UMA histograms to help understand HPACK head of line blocking.

net/quic/quic_chromium_client_session.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // A client specific QuicSession subclass.  This class owns the underlying
 // QuicConnection and QuicConnectionHelper objects.  The connection stores
 // a non-owning pointer to the helper so this session needs to ensure that
 // the helper outlives the connection.
 
 #ifndef NET_QUIC_QUIC_CHROMIUM_CLIENT_SESSION_H_
@@ skipping 118 matching lines @@
       const QuicConfig& config,
       QuicCryptoClientConfig* crypto_config,
       const char* const connection_description,
       base::TimeTicks dns_resolution_end_time,
       QuicClientPushPromiseIndex* push_promise_index,
       base::TaskRunner* task_runner,
       std::unique_ptr<SocketPerformanceWatcher> socket_performance_watcher,
       NetLog* net_log);
   ~QuicChromiumClientSession() override;
 
+  void Initialize() override;
+
   void AddObserver(Observer* observer);
   void RemoveObserver(Observer* observer);
 
   // Attempts to create a new stream.  If the stream can be
   // created immediately, returns OK.  If the open stream limit
   // has been reached, returns ERR_IO_PENDING, and |request|
   // will be added to the stream requets queue and will
   // be completed asynchronously.
   // TODO(rch): remove |stream| from this and use setter on |request|
   // and fix in spdy too.
@@ skipping 121 matching lines @@
 
  protected:
   // QuicSession methods:
   bool ShouldCreateIncomingDynamicStream(QuicStreamId id) override;
   bool ShouldCreateOutgoingDynamicStream() override;
 
   QuicChromiumClientStream* CreateIncomingDynamicStream(
       QuicStreamId id) override;
 
  private:
+  class HpackEncoderDebugVisitor : public QuicHeadersStream::HpackDebugVisitor {
+    void OnUseEntry(const QuicTime::Delta elapsed) override;
+  };
+
+  class HpackDecoderDebugVisitor : public QuicHeadersStream::HpackDebugVisitor {
+    void OnUseEntry(const QuicTime::Delta elapsed) override;
+  };

[Ryan Hamilton, 2016/05/20 21:27:18]

Looks like these can be moved to the .cc file.

[Buck, 2016/05/20 21:41:31]

Done.

+
   friend class test::QuicChromiumClientSessionPeer;
 
   typedef std::set<Observer*> ObserverSet;
   typedef std::list<StreamRequest*> StreamRequestQueue;
 
   QuicChromiumClientStream* CreateOutgoingReliableStreamImpl();
   QuicChromiumClientStream* CreateIncomingReliableStreamImpl(QuicStreamId id);
   // A completion callback invoked when a read completes.
   void OnReadComplete(int result);
 
@@ skipping 59 matching lines @@
   int streams_pushed_count_;
   int streams_pushed_and_claimed_count_;
   base::WeakPtrFactory<QuicChromiumClientSession> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(QuicChromiumClientSession);
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_QUIC_CHROMIUM_CLIENT_SESSION_H_