Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 1987623003: [mojo-edk] Fix test expectations for official builds (Closed)

Created:
4 years, 7 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo-edk] Fix test expectations for official builds CHECK has different (i.e. empty) output on official builds instead of "Check failed" - ASSERT/EXPECT_DEATH* testing macros need different expectations here. BUG=612503 R=jam@chromium.org Committed: https://crrev.com/ab9c83e8baabd5596d9f3702de970dba0cbecc88 Cr-Commit-Position: refs/heads/master@{#394203}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M mojo/edk/system/core_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/edk/system/options_validation_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jam
lgtm
4 years, 7 months ago (2016-05-17 19:39:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987623003/1
4 years, 7 months ago (2016-05-17 19:50:27 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 20:14:30 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 20:16:49 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab9c83e8baabd5596d9f3702de970dba0cbecc88
Cr-Commit-Position: refs/heads/master@{#394203}

Powered by Google App Engine
This is Rietveld 408576698