mojo/edk/system/core_unittest.cc - Issue 1987623003: [mojo-edk] Fix test expectations for official builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/edk/system/core_unittest.cc

Issue 1987623003: [mojo-edk] Fix test expectations for official builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/edk/system/core_unittest.cc

diff --git a/mojo/edk/system/core_unittest.cc b/mojo/edk/system/core_unittest.cc

index 847120c09c62bfeaac53b533b11a1f3f49002716..a25c7af3d08cbf7072dc077b65407e05d5a37f53 100644

--- a/mojo/edk/system/core_unittest.cc

+++ b/mojo/edk/system/core_unittest.cc

@@ -445,7 +445,11 @@ TEST_F(CoreTest, InvalidArguments) {

// (for required pointer arguments) will still cause death, but perhaps not

// predictably.

TEST_F(CoreTest, InvalidArgumentsDeath) {

+#if defined(OFFICIAL_BUILD)

+ const char kMemoryCheckFailedRegex[] = "";

+#else

const char kMemoryCheckFailedRegex[] = "Check failed";

+#endif

// |WaitMany()|:

{

« no previous file with comments | « no previous file | mojo/edk/system/options_validation_unittest.cc » ('j') | no next file with comments »