Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1987413002: Add link preload as=document support

Created:
4 years, 7 months ago by Yoav Weiss
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, tzik, kinuko+watch, jsbell+serviceworker_chromium.org, Yoav Weiss, blink-reviews-html_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, gavinp+loader_chromium.org, loading-reviews_chromium.org, blink-reviews-api_chromium.org, nhiroki, blink-reviews, haraken, loading-reviews+fetch_chromium.org, Nate Chapin, michaeln, tyoshino+watch_chromium.org, gavinp+prerender_chromium.org, serviceworker-reviews, falken, kinuko+serviceworker, horo+watch_chromium.org, igrigorik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add link preload as=document support This CL adds support for document based preloads, targeted at preloading iframes. BUG=593267

Patch Set 1 #

Patch Set 2 : crash fix #

Patch Set 3 : Add LOAD_PREFETCH flag #

Patch Set 4 : crash fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -24 lines) Patch
M content/child/web_url_loader_impl.cc View 1 2 3 chunks +4 lines, -1 line 0 comments Download
M content/child/web_url_request_util.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M content/public/common/request_context_frame_type.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/preload/onerror_event.html View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/preload/onload_event.html View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/resources/test.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/FetchContext.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/FetchRequest.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/RawResource.cpp View 1 2 3 chunks +17 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 1 2 3 3 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/PreloadRequest.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoader.cpp View 1 2 4 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebURLRequest.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceRequest.h View 1 2 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceRequest.cpp View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebURLRequest.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (10 generated)
igrigorik
Description was changed from ========== Add link preload as=document support BUG= ========== to ========== Add ...
4 years, 7 months ago (2016-05-20 22:20:58 UTC) #1
Yoav Weiss
Description was changed from ========== Add link preload as=document support BUG= ========== to ========== Add ...
4 years, 3 months ago (2016-09-07 11:31:43 UTC) #2
Yoav Weiss
The CQ bit was checked by yoav@yoav.ws to run a CQ dry run
4 years, 3 months ago (2016-09-07 12:17:33 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/1987413002/40001
4 years, 3 months ago (2016-09-07 12:17:50 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-09-07 13:44:53 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/293365)
4 years, 3 months ago (2016-09-07 13:44:54 UTC) #6
Yoav Weiss
The CQ bit was checked by yoav@yoav.ws to run a CQ dry run
4 years, 3 months ago (2016-09-07 14:02:54 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/1987413002/60001
4 years, 3 months ago (2016-09-07 14:03:12 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-09-07 15:24:46 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 15:24:47 UTC) #10 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698