third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp - Issue 1987413002: Add link preload as=document support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp

Issue 1987413002: Add link preload as=document support Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: crash fix Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp ('k') | third_party/WebKit/Source/core/html/parser/PreloadRequest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp

diff --git a/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp b/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp

index 9f748b065c1532afcb9df30f011593bba130eb7c..37995f1c4d94b1bd8e036d10cb5e462bfe50f214 100644

--- a/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp

+++ b/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp

@@ -74,7 +74,7 @@ public:

bool allowImage(bool imagesEnabled, const KURL&) const override { return true; }

bool canRequest(Resource::Type, const ResourceRequest&, const KURL&, const ResourceLoaderOptions&, bool forPreload, FetchRequest::OriginRestriction) const override { return true; }

- bool shouldLoadNewResource(Resource::Type) const override { return true; }

+ bool shouldLoadNewResource(Resource::Type, const WebURLRequest::FrameType) const override { return true; }

WebTaskRunner* loadingTaskRunner() const override { return m_runner.get(); }

void setCachePolicy(CachePolicy policy) { m_policy = policy; }