Chromium Code Reviews| Index: blimp/engine/BUILD.gn |
| diff --git a/blimp/engine/BUILD.gn b/blimp/engine/BUILD.gn |
| index 9abf44690ffc4f682dd0313da9ab2e6dc0ce1cb4..40159e132ef0fcad2a79f70806a87bf5f8f0817d 100644 |
| --- a/blimp/engine/BUILD.gn |
| +++ b/blimp/engine/BUILD.gn |
| @@ -560,9 +560,10 @@ if (is_linux) { |
| ] |
| } |
| - # Creates a breakpad symbol file for the engine. This takes a long time so |
| - # it should only be done as part of the official build. |
| + # Crash symbols should only be created and uploaded from official builders. |
| if (is_official_build) { |
| + # Action to create a breakpad symbol file for the engine. This can take |
|
Kevin M
2016/05/18 20:31:46
Capitalize: Breakpad, Engine
marcinjb
2016/05/18 20:42:04
Done.
|
| + # a long time. |
| action("blimp_symbols") { |
| script = "//build/linux/dump_app_syms.py" |
| @@ -593,5 +594,12 @@ if (is_linux) { |
| dump_syms_label, |
| ] |
| } |
| + |
| + # Binary used by the buildbots to upload breakpad symbols. |
|
Kevin M
2016/05/18 20:31:46
THis isn't a binary, just a dep list.
Any reason
marcinjb
2016/05/18 20:42:04
Well, with a level of indirection, symupload gener
|
| + group("symupload") { |
| + deps = [ |
| + "//breakpad:symupload", |
| + ] |
| + } |
| } |
| } |