Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1987363002: Revert of [heap] Do not invoke GC to make heap iterable. (Closed)

Created:
4 years, 7 months ago by Michael Achenbach
Modified:
4 years, 7 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Do not invoke GC to make heap iterable. (patchset #5 id:80001 of https://codereview.chromium.org/1961373003/ ) Reason for revert: Breaks https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3551 Original issue's description: > [heap] Do not invoke GC to make heap iterable. > > Remove kMakeHeapIterableMask since the heap is always iterable. > > BUG=chromium:580959 > LOG=n > > Committed: https://crrev.com/7c1cac4888a248fda3fa6de3624f32a6babb37e9 > Cr-Commit-Position: refs/heads/master@{#36333} TBR=ulan@chromium.org,yangguo@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:580959 Committed: https://crrev.com/0aa3707dc403a5285d216b01d24faa27375ceec4 Cr-Commit-Position: refs/heads/master@{#36335}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -14 lines) Patch
M src/debug/debug.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap/heap.h View 4 chunks +10 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +17 lines, -3 lines 0 comments Download
M src/log.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-log.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/debug-referenced-by.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Achenbach
Created Revert of [heap] Do not invoke GC to make heap iterable.
4 years, 7 months ago (2016-05-18 19:21:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987363002/1
4 years, 7 months ago (2016-05-18 19:21:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 19:22:25 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 19:23:17 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0aa3707dc403a5285d216b01d24faa27375ceec4
Cr-Commit-Position: refs/heads/master@{#36335}

Powered by Google App Engine
This is Rietveld 408576698